Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type definition for offset prop #219

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Add type definition for offset prop #219

merged 1 commit into from
Dec 4, 2019

Conversation

tomeightyeight
Copy link

Resolves issues @ #218

@react-tether-bot
Copy link

Messages
📖 🤔 Hmmm, code coverage is looking low for the whole codebase.
📖 Hey @tomeightyeight, thanks for submitting a pull request! 😸

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/react-tether.js (0/0) 100% (0/0) 100% (0/0) 100% (0/0) 100%
src/TetherComponent.jsx (70/82) 85% (72/84) 86% (22/28) 79% (55/63) 87%
Total (70/82) 85% (72/84) 86% (22/28) 79% (55/63) 87%

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.207% when pulling ac453dd on tomeightyeight:bugfix/add-missing-type-definition-for-offset into c8a5ece on danreeves:master.

danreeves
danreeves approved these changes Dec 4, 2019
View reviewed changes
Copy link
Owner

@danreeves danreeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danreeves danreeves merged commit ea5737e into danreeves:master Dec 4, 2019
@danreeves
Copy link
Owner

Published in 2.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danreeves danreeves danreeves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomeightyeight @react-tether-bot @coveralls @danreeves @m7kvqbe1