Return related materials ordered by query instead of covers #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current version we retrieve object ids from search result, pass these to the cover service in the same order and merge material data intro the provided results. However practice has shown that the cover service does not necessarily preserve the order of the requested ids in the response. This leads to a situation where the related materials will not have the same order as in the linked search result. To preserve the order of the materials from the search result we merge cover data into the materials instead and filter away any materials without a cover.
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 81.20% 81.20%
=======================================
Files 47 47
Lines 649 649
Branches 152 152
=======================================
Hits 527 527
Misses 111 111
Partials 11 11
Continue to review full report at Codecov.
|
cableman
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version we retrieve object ids from search result,
pass these to the cover service in the same order and merge material
data intro the provided results.
However practice has shown that the cover service does not
necessarily preserve the order of the requested ids in the response.
This leads to a situation where the related materials will not have
the same order as in the linked search result.
To preserve the order of the materials from the search result we
merge cover data into the materials instead and filter away any
materials without a cover.