Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding secrets to helm #1541

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

clayrosenthal
Copy link
Contributor

@clayrosenthal clayrosenthal commented May 30, 2024

This PR helps separate some secrets out from the standard configmap, the changes include:

  • Adding an auth section to the helm values yaml
  • Adding to the auth section keys to fill in for various secrets
  • Adding these secrets to the various deployments as env vars, to avoid any changes to the backend code
  • Incrementing chart version

Fixes #1540 and helps with #971

Copy link

vercel bot commented May 30, 2024

@clayrosenthal is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yuhongsun96 yuhongsun96 merged commit 0ea257d into danswer-ai:main Jun 1, 2024
1 check failed
ThomasRitaine pushed a commit to ThomasRitaine/chatdoc that referenced this pull request Jun 4, 2024
* adding secrets to helm

* incrementing chart version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes/Helm secrets are stored in configmap
2 participants