Deprecate task.h in favor of qcorotask.h (#70) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 16 files + 2 16 suites +2 11m 53s ⏱️ + 1m 36s For more details on these failures, see this check. Results for commit f7466b3. ± Comparison against base commit df058a9. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
The task.h (QCoro/Task) header is deprecated now and produces a warning that users should switch to qcorotask.h (QCoro/QCoroTask) header. The warning can be disabled by passing -DQCORO_NO_WARN_DEPRECATED_TASK_H to the compiler. The header will be removed in some future versions of QCoro.
danvratil
force-pushed
the
deprecate-task-header
branch
2 times, most recently
from
8b31d88
to
df92323
Compare
danvratil
force-pushed
the
deprecate-task-header
branch
from
8b31d88
to
f7466b3
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task.h (QCoro/Task) header is deprecated now and produces a warning
that users should switch to qcorotask.h (QCoro/QCoroTask) header. The
warning can be disabled by passing -DQCORO_NO_WARN_DEPRECATED_TASK_H
to the compiler. The header will be removed in some future versions of
QCoro.