Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15510 build: Test with release BuildType #14403

Closed
wants to merge 1 commit into from
Closed

DAOS-15510 build: Test with release BuildType #14403

wants to merge 1 commit into from
+3 −1

Conversation

liw
Copy link
Contributor

@liw liw commented May 20, 2024 •
edited
Loading

Not for landing.

Skip-test: true
Skip-unit-tests: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

Ticket title is 'DMG perf degradation between 2.6TB1 and 2.4.2'
Status is 'Awaiting Verification'
Labels: '2.6.0tb1,tds,test_priority'
https://daosio.atlassian.net/browse/DAOS-15510

@liw liw force-pushed the liw/debug-dmg branch 3 times, most recently from 572fbb9 to 6e5fea2 Compare May 20, 2024 13:16
@liw
DAOS-15510 build: Test with release BuildType
a7b5135 
Doc-only: false
Skip-test: true
Skip-unit-tests: true
Signed-off-by: Li Wei <wei.g.li@intel.com>
Required-githooks: true
@liw liw changed the base branch from master to release/2.6 May 28, 2024 23:52
@liw
Copy link
Contributor Author

liw commented May 28, 2024

Rebased to the latest release/2.6.

@liw liw closed this Jun 9, 2024
@liw liw deleted the liw/debug-dmg branch June 9, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liw