Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15858 test: Increase timeout for test_lost_majority_ps_replicas #14411

Merged
merged 2 commits into from
May 24, 2024
Merged

DAOS-15858 test: Increase timeout for test_lost_majority_ps_replicas #14411

merged 2 commits into from
May 24, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented May 21, 2024

…icas

Increasing test timeout by 30 seconds for PoolListConsolidationTest test cases.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-15858 test: Increase test timeout for test_lost_majority_ps_repl…
ca9c134 
…icas

Increasing test timeout by 30 seconds for PoolListConsolidationTest test
cases.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested review from a team as code owners May 21, 2024 18:07
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

Ticket title is 'recovery/pool_list_consolidation.py:PoolListConsolidationTest.test_lost_majority_ps_replicas - test timeout in tearDown'
Status is 'In Progress'
Labels: 'ci_impact,daily_test,triaged'
https://daosio.atlassian.net/browse/DAOS-15858

@phender phender changed the title DAOS-15858 test: Increase test timeout for test_lost_majority_ps_repl… DAOS-15858 test: Increase timeout for test_lost_majority_ps_replicas May 21, 2024
@phender
Merge branch 'master' into pahender/DAOS-15858
cdd80b7 
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender
Copy link
Contributor Author

phender commented May 24, 2024

All tests passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14411/3/testReport/FTEST_recovery/PoolListConsolidationTest/

@phender phender requested a review from a team May 24, 2024 20:37
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 24, 2024
@phender phender merged commit 6792631 into master May 24, 2024
42 of 44 checks passed
@phender phender deleted the pahender/DAOS-15858 branch May 24, 2024 20:50
phender added a commit that referenced this pull request May 28, 2024
@phender
DAOS-15858 test: Increase test timeout for test_lost_majority_ps_repl…
32769da 
…icas (#14411)

Increasing test timeout by 30 seconds for PoolListConsolidationTest test
cases.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender mentioned this pull request May 28, 2024
Merged
18 tasks
phender added a commit that referenced this pull request May 29, 2024
@phender
DAOS-15858 test: Increase test timeout for test_lost_majority_ps_repl…
38a65eb 
…icas (#14411) (#14462)

Increasing test timeout by 30 seconds for PoolListConsolidationTest test
cases.

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimizukko shimizukko shimizukko approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phender @shimizukko @daltonbohning