Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-4033 control: attempt protobuf defn sharing across ctl & mgmt #1755

Closed
wants to merge 29 commits into from
Closed

DAOS-4033 control: attempt protobuf defn sharing across ctl & mgmt #1755

wants to merge 29 commits into from

Conversation

tanabarr
Copy link
Contributor

Signed-off-by: Tom Nabarro tom.nabarro@intel.com

@tanabarr
DAOS-3647 control: improve grpc fanout for system commands
9321ef0 
Give symmetry to the handling of system commands by returning generic
per-rank results through a harness action helper. Helper issues gRPC
requests to each host in system membership.

- improve fanout by returning rank results from harness action
- test coverage for fanout operations over system membership
- test coverage for harness action helper
- test coverage for system membership
- proto changes to return rank results in grpc fanout
- make system commands synchronous, waiting on harness activity

dmg "system query" command should verify member responsiveness and
update status of member accordingly.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
increase membership unit test coverage
6d156d2 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
UpdateMemberStates() reads state from result directly
d6f7aae 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
fix conversion of timeout values
d02ae40 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
apply action verb to rank results
c110f9c 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
system query should work if leader instance is stopped
c82a311 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
build fix
4850c96 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
fix build with different versions of go
dd2a262 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
reset inadvertently changed scons_local submodule reference
c7f886a 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
remove dependency on ioserver pkg from dmg
14b2366 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
Merge branch 'master' into tanabarr/control-system-fanout
81f5580
@tanabarr
DAOS-3647 control: add activity check to system query
d9ee06a 
dmg "system query" command should verify member responsiveness and
update status of member accordingly.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
DAOS-3647 control: stop io_server through instance runner
b238b77 
Enable daos_io_server processes to be stopped by the daos_server
harness through the instance runner interface. This create a
simple backup kill method in case inband shutdown fails.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>

Conflicts:
	src/control/server/mgmt_svc.go
@tanabarr
use local variables when possible
86b90e4 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
query ranks over grpc regardless of MS started state
f8129ba 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
enable system stop --force option to kill rank directly from harness
d3185d2 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
rename instance IsStarted to IsRunning
4791846 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
HarnessClient interface
a2e59ca 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
change harnessAction to HarnessClient interface and add getMSMemberAd…
c53f1c4 
…dress()

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
add success test cases for drpc methods
b9b517d 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
fix build
55246ab 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
mock kill rank in drpc handler test
c583c14 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
build fixes
a943cf6 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
build fix
5949d5c 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
build fix
5a7b224 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
build fix
7bc6b0f 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
add request parsing to dmg system command tests
abb05a9 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
consolidate Rank prefix hack into helper methods to ease replacement
0280645 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr
attempt protobuf defn sharing across ctl & mgmt
dbe9fd1 
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr tanabarr requested a review from mjmac January 22, 2020 17:42
@tanabarr tanabarr requested a review from kjacque January 22, 2020 17:42
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1755/1/execution/node/188/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1755/1/execution/node/195/log

mjmac
mjmac reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@mjmac mjmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a lot of change for minimal value... Couldn't a similar end result be achieved using symlinks?

src/proto/Makefile
@@ -1,5 +1,5 @@
#
# (C) Copyright 2019 Intel Corporation.
# (C) Copyright 2020 Intel Corporation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Copyright updates are supposed to be a range, aren't they? i.e. 2019-2020, since the file was created in 2019 and updated in 2020.

@daosbuild1
Copy link
Collaborator

Test stage Build on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1755/1/execution/node/203/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Ubuntu 18.04 with Clang completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1755/1/execution/node/192/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-1755/1/execution/node/189/log

kjacque
kjacque reviewed Jan 22, 2020
View reviewed changes
src/proto/Makefile
common/proto/srv/srv.pb.go\
common/proto/ctl/rank.pb.go\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, when I asked for this I assumed that it was trivial to import protobuf files from other directory locations. If we wind up duplicating either way, maybe it should just be left the way it already was.

@tanabarr tanabarr force-pushed the tanabarr/control-system-status branch from 5dc6514 to 515158c Compare January 23, 2020 09:51
@tanabarr tanabarr closed this Jan 21, 2021
@tanabarr tanabarr deleted the tanabarr/control-protobuf-common branch January 21, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmac mjmac mjmac left review comments

@kjacque kjacque kjacque left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanabarr @daosbuild1 @mjmac @kjacque