added default value and placeholder (#2091)

* added default value and placeholder * removed default value * added dafualt value back * data field is now optional with default value * change text in placeholder
daostack · Sep 7, 2020 · eb3d39f · eb3d39f
1 parent 973cd43
commit eb3d39f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/components/Proposal/Create/PluginForms/CreateKnownGenericPluginProposal.tsx b/src/components/Proposal/Create/PluginForms/CreateKnownGenericPluginProposal.tsx
@@ -171,7 +171,10 @@ class CreateKnownPluginProposal extends React.Component<IProps, IState> {
     const callValues = [];
 
     for (const field of currentAction.getFields()) {
-      const callValue = field.callValue(values[field.name]);
+      let callValue = field.callValue(values[field.name]);
+      if (!callValue && field.defaultValue){
+        callValue = field.defaultValue;
+      }
       values[field.name] = callValue;
       callValues.push(callValue);
     }
@@ -380,7 +383,7 @@ class CreateKnownPluginProposal extends React.Component<IProps, IState> {
                 }
 
                 if (field.type.includes("bytes")) {
-                  if (!isHexString(value)) {
+                  if (value && !isHexString(value)) {
                     errors[field.name] = "Must be a hex value";
                   }
                 }

diff --git a/src/genericPluginRegistry/plugins/NFTManager.json b/src/genericPluginRegistry/plugins/NFTManager.json
@@ -30,7 +30,9 @@
           {
             "label": "Data",
             "name": "data",
-            "placeholder": ""
+            "placeholder": "Arbitrary data to transfer (0x0 means no data)",
+            "defaultValue": "0x0",
+            "optional": true
           }
         ],
         "abi": {