Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added default value and placeholder #2091

Merged
merged 6 commits into from
Sep 6, 2020
Merged

added default value and placeholder #2091

merged 6 commits into from
Sep 6, 2020

Conversation

roienatan
Copy link
Contributor

@roienatan roienatan commented Aug 30, 2020 •
edited
Loading

resolves: #2087

@arsena21

@roienatan roienatan added the 2.0 label Aug 30, 2020
@roienatan roienatan temporarily deployed to alchemy-data-input-opti-jfnhkx August 30, 2020 20:58 Inactive
@roienatan roienatan temporarily deployed to alchemy-data-input-opti-jfnhkx August 31, 2020 09:09 Inactive
@roienatan roienatan temporarily deployed to alchemy-data-input-opti-jfnhkx August 31, 2020 12:33 Inactive
@roienatan roienatan temporarily deployed to alchemy-data-input-opti-jfnhkx September 1, 2020 16:24 Inactive
@roienatan roienatan temporarily deployed to alchemy-data-input-opti-jfnhkx September 2, 2020 10:13 Inactive
dkent600
dkent600 suggested changes Sep 2, 2020
View reviewed changes
src/components/Proposal/Create/PluginForms/CreateKnownGenericPluginProposal.tsx
@@ -380,7 +383,7 @@ class CreateKnownPluginProposal extends React.Component<IProps, IState> {
}

if (field.type.includes("bytes")) {
if (!isHexString(value)) {
if (value && !isHexString(value)) {
Copy link
Contributor

@dkent600 dkent600 Sep 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be wrong to expect this to be a hex string. the data type is bytes. I seem to recall the contract saying it can be any data. Are you sure this cannot in fact be any string value? This is what you are implying in the placeholder text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is hex string

src/genericPluginRegistry/plugins/NFTManager.json Outdated
@@ -30,7 +30,9 @@
{
"label": "Data",
"name": "data",
"placeholder": ""
"placeholder": "Arbitrary data to transfer (0x0)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be: "Arbitrary data to transfer (0x0 means no data)"

@roienatan roienatan temporarily deployed to alchemy-data-input-opti-jfnhkx September 2, 2020 15:20 Inactive
@orenyodfat orenyodfat merged commit 4a13b50 into dev-2 Sep 6, 2020
@roienatan roienatan deleted the data-input-optional-nft branch September 6, 2020 06:47
orenyodfat pushed a commit that referenced this pull request Sep 7, 2020
@roienatan
added default value and placeholder (#2091)
eb3d39f 
* added default value and placeholder

* removed default value

* added dafualt value back

* data field is now optional with default value

* change text in placeholder
orenyodfat added a commit that referenced this pull request Sep 12, 2020
@orenyodfat @roienatan @dkent600
merge to master-2 (#2110)
f62356e 
* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* Support DAOs sort by total holdings (#2085)

* fething daos balances

* Support for DAOs total holdings ; sorting by total holdings

* Update translation.json

Missing comma after resolving conflicts.

* Minor adjustments due to changes in DAOs balances serivce that now returns balances only for registered DAOs (#2089)

* Updated chrome driver for tests (#2093)

* updated chrome driver for tests

* updated version also for seleniumArgs

* automatic update to the latest chrome driver

* updated webdriverio

* updated selenium

* Update .travis.yml

Removing auto version fetch as I'm not sure if it's working properly right now.
Will check it next time.

* updated dependencies (#2096)

* automatically refresh voting status (#2102)

* added default value and placeholder (#2091)

* added default value and placeholder

* removed default value

* added dafualt value back

* data field is now optional with default value

* change text in placeholder

* Support for Join and FundingRequest proposals (read only) (#2099)

* Update subgraph endpoints to v8_12 (#2108)

* update subgraph enpoints to v8_12

* also for mainnet

* updated arc.js 54 (#2109)

* release dev-2 to master-2 (#2079)

* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>

* Updated daocreator version (#2114)

* updated daocreator version

* updated package lock

* fix SchemeFactory case for copying params (#2121)

* Fix bad ui when using autocomplete input in chrome (#2127)

* fix bad ui when using autocomplete input in chrome

* changes

* fix misplaced against vote button (#2123)

* fix vote feedback alignment (#2128)

* Eliminate fortawesome (#2129)

* eliminate fortawesome

* Update github.svg

New line at EOF

* missing fortawesome for dao creator

* fix bad layout of an icon on Safari

* Create CODEOWNERS

* updated arc.js version to 55 (#2130)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenyodfat orenyodfat orenyodfat approved these changes

@dkent600 dkent600 Awaiting requested review from dkent600

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roienatan @dkent600 @orenyodfat