Bounty network integration

[A-Zak]

This PR is for the integration of a generic scheme and a corresponding UI for interacting with the bounty networks contract.
This will allow our DAOs to create bounties, accept fulfillers, and pay them out when the work is done.
This is important for the separation of ideation and implementation (allow people to suggest ideas even if they can't implement them) & pseudo escrow funding (only transfer the money after the work is done).

[edsonayllon]

This PR includes a bugfix. In some forms for Generic Schemes, fields can be asking for a number. All user input fields are parsed with .trim(), which is only applicable to strings, producing the error userValue.trim() is not a function.

A commit included fixes this, by first checking if the field is a string before parsing it with .trim()

} else if (typeof userValue === 'string') {
    userValue = userValue.trim();
}

c3afad7

[edsonayllon]

Note: This PR alters the CSS for Generic Schemes, as previous CSS of the new proposal modal window held the sidebar and main content as a single column. This PR uses flexbox to maintain 2 columns. Additionally, in cases where fields would overflow from a user's browser, and become inaccessible to the user, a maximum height was provided to the modal, where content can be accessed with a scrollbar. The maximum height was selected to accommodate 720p displays at minimum.

96eabc5

[dkent600]

Can't see the preview app to review the UI

[dkent600]

I think this url should be less generic and contain something specific to this contract, like /dao/${daoAvatarAddress}/scheme/${schemeId}/openbounties/

[edsonayllon]

Updated in 7c89ec3

[dkent600]

openBountiesTabClass

[edsonayllon]

Updated in 7c89ec3

[tibetsprague]

@edsonayllon would be great to get this on, can you address @dkent600 last comments and resolve conflicts with the latest dev?

[edsonayllon]

Sorry, just saw this. Will get on it

[tibetsprague]

@EzraWeller this one needs some serious testing before we merge in

[tibetsprague]

@edsonayllon also check the build, looks like a lint issue and a testing issue related to paths

[edsonayllon]

I made some quick edits on Github. Am trying to load on my computer to go over it, but the install seems to be failing. What's the recommended version of Node? I've tried Node 10 and 12.

Edit: Node 11 seems to work. The Readme needs updating for Docker. It looks like alchemy-server was changed in the docker-compose file.

[edsonayllon]

Checks are passing.

I wasn't able to load the app in staging. Docker started a client in port 3000, conflicting with npm run start-staging, so I wasn't able to load the subgraph. So, all the edits were made without running the app to test it firsthand, unfortunately. If there's an updated process for running the Rinkeby client locally let me know.

[dkent600]

@edsonayllon

If there's an updated process for running the Rinkeby client locally let me know.

npm run build-staging

[edsonayllon]

npm run build-staging

There's no build-staging in my package.json currently.

[dkent600]

@edsonayllon

npm run build-staging

There's no build-staging in my package.json currently.

So sorry, npm run start-staging

[edsonayllon]

Ok, nevermind. I guess those DAOs of the same name were recently created. I thought I wasn't on the Rinkeby deployment. I found dxDAO by using search.

Everything seems to be working as it was. Open Bounties tab routing works and proposals are the same.

Might consider adding some filtering options in the All DAOs page, if Alchemy ever reaches that degree of saturation with DAOs.

[tibetsprague]

@dkent600 @jellegerbrandy i feel good about merging this now! you guys have outstanding reviews