Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and fix issues relating 3box operations #2018

Merged
merged 31 commits into from
Aug 17, 2020
Merged

refactor and fix issues relating 3box operations #2018

merged 31 commits into from
Aug 17, 2020

Conversation

dkent600
Copy link
Contributor

@dkent600 dkent600 commented Jul 29, 2020 •
edited
Loading

  • Refactors 3box in prep for adding threads.
  • Addresses issues such as when switching metamask accounts. Primary improvement is probably to cast account address to lower case to enable account comparisons and accounts used as keys, to resolve properly.
  • adds typings definitions to help self-document the hard-to-understand code in profilesReducer
  • refactors some of profilesReducer to clarify and robustify the code
  • modifies AccountProfile UI logic to only go into edit mode once the account is fully connected and we are sure that the user can edit the profile. Particularly at issue is when the metamask and alchemy-cached accounts differ. Before allowing the user to edit. must be connected to metamask to assure this is not the case.
  • handles case where logging out and there is a big console error from our 3Box code and who knows what else happens when the currentAccountAddress goes to null.
  • not fixed: can have an issue described here
  • does not use the latest 3Box due to this, but does use the next prior version

@dkent600 dkent600 marked this pull request as draft July 29, 2020 10:33
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 July 29, 2020 10:33 Inactive
@dkent600 dkent600 changed the title add3BoxCommentsUsingThreads refactor and fix issues relating 3box operations Jul 29, 2020
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 July 29, 2020 11:14 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 July 29, 2020 13:41 Inactive
@dkent600
Copy link
Contributor Author

Waiting for this from 3Box: 3box/3box-js#874

@dkent600 dkent600 self-assigned this Jul 30, 2020
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 July 30, 2020 13:37 Inactive
@dkent600 dkent600 force-pushed the add3BoxCommentsUsingThreads branch from f71de3c to 86e482a Compare July 30, 2020 19:46
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 July 30, 2020 19:46 Inactive
@dkent600 dkent600 added the 2.0 label Aug 3, 2020
@dkent600 dkent600 force-pushed the add3BoxCommentsUsingThreads branch from 86e482a to 3679a02 Compare August 5, 2020 19:33
@dkent600 dkent600 had a problem deploying to alchemy-add3boxcomments-jjgmo6 August 5, 2020 19:33 Failure
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 August 5, 2020 19:34 Inactive
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 August 5, 2020 19:40 Inactive
@dkent600 dkent600 had a problem deploying to alchemy-add3boxcomments-jjgmo6 August 10, 2020 14:20 Failure
@dkent600 dkent600 had a problem deploying to alchemy-add3boxcomments-jjgmo6 August 10, 2020 15:02 Failure
@dkent600
Copy link
Contributor Author

dkent600 commented Aug 10, 2020 •
edited
Loading

Blocked by this from 3Box: 3box/3box-js#889

@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 August 11, 2020 10:39 Inactive
@dkent600
Copy link
Contributor Author

Blocked on this: 3box/3box-js#890

@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 August 11, 2020 18:05 Inactive
@dkent600 dkent600 removed the Blocked label Aug 12, 2020
@dkent600 dkent600 marked this pull request as ready for review August 12, 2020 16:22
@dkent600 dkent600 had a problem deploying to alchemy-add3boxcomments-jjgmo6 August 12, 2020 16:33 Failure
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 August 12, 2020 19:55 Inactive
@dkent600 dkent600 had a problem deploying to alchemy-add3boxcomments-jjgmo6 August 13, 2020 13:41 Failure
@dkent600 dkent600 temporarily deployed to alchemy-add3boxcomments-jjgmo6 August 17, 2020 10:34 Inactive
@dkent600 dkent600 merged commit da3b547 into dev-2 Aug 17, 2020
@dkent600 dkent600 deleted the add3BoxCommentsUsingThreads branch August 17, 2020 10:38
orenyodfat added a commit that referenced this pull request Aug 17, 2020
@orenyodfat @roienatan @dkent600
release dev-2 to master-2 (#2079)
b3f466f 
* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
orenyodfat added a commit that referenced this pull request Sep 7, 2020
@orenyodfat @roienatan @dkent600
release dev-2 to master-2 (#2079)
ca88266 
* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
orenyodfat pushed a commit that referenced this pull request Sep 7, 2020
@dkent600
refactor and fix issues relating 3box operations (#2018)
97ec9ce 
* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock
orenyodfat added a commit that referenced this pull request Sep 7, 2020
@orenyodfat @roienatan @dkent600
release dev-2 to master-2 (#2079)
98a3464 
* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
orenyodfat added a commit that referenced this pull request Sep 12, 2020
@orenyodfat @roienatan @dkent600
merge to master-2 (#2110)
f62356e 
* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* Support DAOs sort by total holdings (#2085)

* fething daos balances

* Support for DAOs total holdings ; sorting by total holdings

* Update translation.json

Missing comma after resolving conflicts.

* Minor adjustments due to changes in DAOs balances serivce that now returns balances only for registered DAOs (#2089)

* Updated chrome driver for tests (#2093)

* updated chrome driver for tests

* updated version also for seleniumArgs

* automatic update to the latest chrome driver

* updated webdriverio

* updated selenium

* Update .travis.yml

Removing auto version fetch as I'm not sure if it's working properly right now.
Will check it next time.

* updated dependencies (#2096)

* automatically refresh voting status (#2102)

* added default value and placeholder (#2091)

* added default value and placeholder

* removed default value

* added dafualt value back

* data field is now optional with default value

* change text in placeholder

* Support for Join and FundingRequest proposals (read only) (#2099)

* Update subgraph endpoints to v8_12 (#2108)

* update subgraph enpoints to v8_12

* also for mainnet

* updated arc.js 54 (#2109)

* release dev-2 to master-2 (#2079)

* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>

* Updated daocreator version (#2114)

* updated daocreator version

* updated package lock

* fix SchemeFactory case for copying params (#2121)

* Fix bad ui when using autocomplete input in chrome (#2127)

* fix bad ui when using autocomplete input in chrome

* changes

* fix misplaced against vote button (#2123)

* fix vote feedback alignment (#2128)

* Eliminate fortawesome (#2129)

* eliminate fortawesome

* Update github.svg

New line at EOF

* missing fortawesome for dao creator

* fix bad layout of an icon on Safari

* Create CODEOWNERS

* updated arc.js version to 55 (#2130)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
orenyodfat pushed a commit that referenced this pull request Sep 13, 2020
@namesty @cbrzn
@roienatan @dkent600
Token Trade Implementation (#2055)
3e1e554 
* [WIP] Token Trade Plugin

* CreateProposal and ProposalSummary created for TokenTrade (untested)

* Token trade fixes for BN.js amoun types

* [WIP] Create token trade proposal

* updating images

* TokenTrade proposal summary fixed

* Eliminated console.logs

* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Form service - i18next

* [WIP] styling details

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

* Support DAOs sort by total holdings (#2085)

* fething daos balances

* Support for DAOs total holdings ; sorting by total holdings

* Update translation.json

Missing comma after resolving conflicts.

* Styling for Token Trade Proposal Summary and Changed JoinAndQuit naming

* Merge fixes

* Added package.lock

* Minor adjustments due to changes in DAOs balances serivce that now returns balances only for registered DAOs (#2089)

* bumping arc.js version

* Updated chrome driver for tests (#2093)

* updated chrome driver for tests

* updated version also for seleniumArgs

* automatic update to the latest chrome driver

* updated webdriverio

* updated selenium

* Update .travis.yml

Removing auto version fetch as I'm not sure if it's working properly right now.
Will check it next time.

* dev-2 merged

* lint error fix

* fix lint

* removed unused import

* added token trade to required plugin permissions object

Co-authored-by: cbrzn <cesarbrazon10@gmail.com>
Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
dkent600 added a commit that referenced this pull request Sep 15, 2020
@dkent600
refactor and fix issues relating 3box operations (#2018)
6060d76 
* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock
dkent600 added a commit that referenced this pull request Sep 22, 2020
@dkent600
refactor and fix issues relating 3box operations (#2018)
5d7969e 
* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock
dkent600 added a commit that referenced this pull request Sep 23, 2020
@dkent600
refactor and fix issues relating 3box operations (#2018)
885aa88 
* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock
dkent600 added a commit that referenced this pull request Sep 30, 2020
@dkent600
refactor and fix issues relating 3box operations (#2018)
372cc36 
* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock
orenyodfat pushed a commit that referenced this pull request Oct 4, 2020
@dkent600
refactor and fix issues relating 3box operations (#2018)
f728d21 
* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock
orenyodfat added a commit that referenced this pull request Oct 4, 2020
@orenyodfat @roienatan @dkent600
release dev-2 to master-2 (#2079)
25bdcda 
* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
orenyodfat pushed a commit that referenced this pull request Oct 4, 2020
@namesty @cbrzn
@roienatan @dkent600
Token Trade Implementation (#2055)
29f3217 
* [WIP] Token Trade Plugin

* CreateProposal and ProposalSummary created for TokenTrade (untested)

* Token trade fixes for BN.js amoun types

* [WIP] Create token trade proposal

* updating images

* TokenTrade proposal summary fixed

* Eliminated console.logs

* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Form service - i18next

* [WIP] styling details

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

* Support DAOs sort by total holdings (#2085)

* fething daos balances

* Support for DAOs total holdings ; sorting by total holdings

* Update translation.json

Missing comma after resolving conflicts.

* Styling for Token Trade Proposal Summary and Changed JoinAndQuit naming

* Merge fixes

* Added package.lock

* Minor adjustments due to changes in DAOs balances serivce that now returns balances only for registered DAOs (#2089)

* bumping arc.js version

* Updated chrome driver for tests (#2093)

* updated chrome driver for tests

* updated version also for seleniumArgs

* automatic update to the latest chrome driver

* updated webdriverio

* updated selenium

* Update .travis.yml

Removing auto version fetch as I'm not sure if it's working properly right now.
Will check it next time.

* dev-2 merged

* lint error fix

* fix lint

* removed unused import

* added token trade to required plugin permissions object

Co-authored-by: cbrzn <cesarbrazon10@gmail.com>
Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
orenyodfat added a commit that referenced this pull request Oct 4, 2020
@orenyodfat @roienatan
@dkent600 @namesty @cbrzn
Release 2 (#2159)
faf22e6 
* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* Support DAOs sort by total holdings (#2085)

* fething daos balances

* Support for DAOs total holdings ; sorting by total holdings

* Update translation.json

Missing comma after resolving conflicts.

* Minor adjustments due to changes in DAOs balances serivce that now returns balances only for registered DAOs (#2089)

* Updated chrome driver for tests (#2093)

* updated chrome driver for tests

* updated version also for seleniumArgs

* automatic update to the latest chrome driver

* updated webdriverio

* updated selenium

* Update .travis.yml

Removing auto version fetch as I'm not sure if it's working properly right now.
Will check it next time.

* updated dependencies (#2096)

* updated arc.js 54 (#2109)

* release dev-2 to master-2 (#2079)

* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>

* Updated daocreator version (#2114)

* updated daocreator version

* updated package lock

* updated arc.js version to 55 (#2130)

* Token Trade Implementation (#2055)

* [WIP] Token Trade Plugin

* CreateProposal and ProposalSummary created for TokenTrade (untested)

* Token trade fixes for BN.js amoun types

* [WIP] Create token trade proposal

* updating images

* TokenTrade proposal summary fixed

* Eliminated console.logs

* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* Form service - i18next

* [WIP] styling details

* Plugin manager create proposal modal has a left border and padding like the other modals (#2071)

* fix UI where votes screwed up (#2070)

* Better UI for DAO history page (#2069)

* Update documentation (#2062)

* updated documentation regarding i18next

* updated with global variables for styling

* example added

* better example

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* fix issue when a proposal card is not always clickable (#2077)

* revert subgraph endpoint domain (#2078)

* Support DAOs sort by total holdings (#2085)

* fething daos balances

* Support for DAOs total holdings ; sorting by total holdings

* Update translation.json

Missing comma after resolving conflicts.

* Styling for Token Trade Proposal Summary and Changed JoinAndQuit naming

* Merge fixes

* Added package.lock

* Minor adjustments due to changes in DAOs balances serivce that now returns balances only for registered DAOs (#2089)

* bumping arc.js version

* Updated chrome driver for tests (#2093)

* updated chrome driver for tests

* updated version also for seleniumArgs

* automatic update to the latest chrome driver

* updated webdriverio

* updated selenium

* Update .travis.yml

Removing auto version fetch as I'm not sure if it's working properly right now.
Will check it next time.

* dev-2 merged

* lint error fix

* fix lint

* removed unused import

* added token trade to required plugin permissions object

Co-authored-by: cbrzn <cesarbrazon10@gmail.com>
Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>

* fix wrong plugin name (#2136)

* Update travis.yml to run test coverage (#2132)

* update travis.yml to run test coverage

* added coverall and configurations

* added more coverage configurations

* updated configurations

* modify travis.yml

* update travis node js version

* Update .travis.yml

* Update package.json

Co-authored-by: orenyodfat <orenyodfat@users.noreply.github.com>

* fix no side bar modal scrolling (#2141)

* Update arc.js 56 ; use polling (#2140)

* update arc.js 56

* use polling

* polling in redemptions page

* change all subscribe to polling

* fix proposals counters

* fix staking data not automatically updated

* fix redemption test

* run all tests

* fix failure in proposal summery

* missing redeem button in proposal summary

* remove unnecessary comments

* added global variable to graph poll interval ; updated interval to 30 seconds

* Support Join and FundingRequest creation in PluginManager (#2144)

* added support for join and fr on plugin manager ; need to update arc.js to proceed

* fix error of property pluginName does not exist on type never

* Robust UI to the Enable Predictions button to look good on both Windows and Mac (#2149)

* Added fieldset to Add params and Remove params to distinguish between them (#2157)

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Co-authored-by: Doug Kent <dkent600@users.noreply.github.com>
Co-authored-by: Nestor Amesty <nestor09amesty@gmail.com>
Co-authored-by: cbrzn <cesarbrazon10@gmail.com>
dkent600 added a commit that referenced this pull request Oct 7, 2020
@dkent600
refactor and fix issues relating 3box operations (#2018)
948704f 
* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock
dkent600 added a commit that referenced this pull request Oct 12, 2020
@dkent600
refactor and fix issues relating 3box operations (#2018)
f776584 
* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock
dkent600 added a commit that referenced this pull request Oct 13, 2020
@dkent600 @roienatan
3box threads (#2146)
8b10671 
* Updated arc.js, test env and subgraph (#2072)

* Updated arc.js, test env and subgraph

* join and quit --> join to match new arc.js

* updated doc to Join instead of JoinAndQuit

* refactor and fix issues relating 3box operations (#2018)

* upgrade provider packages

* update package-lock

* remove webpack from dependencies

* package-lock

* lint

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* remove unused webReducer stuff

* merge conflict errors

* added some i18next

* upgrade provider packages

* remove webpack from dependencies

* package-lock

* refactor, fix bugs

* better console info on errors

* clean up account profile loguc

* merge conflict errors

* added some i18next

* package-lock

* 3box fix for identity-wallet

* fix bug in SAVE_THREEBOX

* revert to 3box 1.20.3

* fix error in follow

* remove Try Edit button

* clean up canEdit logic

* remove console.log statements

* fix merge conflict

* fix compile error

* Update translation.json

* update package-lock

* starting with joining a thread

update package-lock

optimizations, upgrade 3box to 1.22.0

levelup update levelup to work-around 3box issue

lots more functionality

more good stuff

more grooviness!

add markdown ability

improve error messages a bit

help text, i18next

fix update after new comment

really fix new post subscription

add delete post button

compile error

translations, tooltips

fix logging out issues

allow resizing of markdown editor

conform prompt before deletion

fetching spinner

PR comments, remove Disqus from DAO landing page

create ThreeBoxThreads component

clone threads across the app

* fix character case error

* lint, console statements

* remove test coverage from travis

* colors to global variables

* removed terniary logic for conditional rendering

Co-authored-by: roienatan <34843014+roienatan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenyodfat orenyodfat orenyodfat left review comments

@roienatan roienatan roienatan approved these changes

Assignees

@dkent600 dkent600

Labels
2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkent600 @orenyodfat @roienatan