Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different message when no write methods found in ABI #2184

Merged
merged 2 commits into from
Oct 11, 2020

Conversation

roienatan
Copy link
Contributor

resolves: #2183

@roienatan roienatan added the 2.0 label Oct 11, 2020
@roienatan roienatan temporarily deployed to alchemy-different-error-csf8kg October 11, 2020 08:27 Inactive
@@ -52,6 +52,7 @@
"Validate Digits" : "Must contain only digits",
"Call to Contract": "This proposal will call the following ",
"No ABI": "No ABI found for target contract, please verify the ",
"No Write Methods": "No write methods found for target contract, please verify the ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if no "write" methods are found so verify the contract will not help.
I think it should be only
No write methods found for target contract

@roienatan roienatan temporarily deployed to alchemy-different-error-csf8kg October 11, 2020 09:06 Inactive
@roienatan roienatan merged commit 9b9a53d into dev-2 Oct 11, 2020
@roienatan roienatan deleted the different-error-when-no-write-functions branch October 11, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants