openapi schema generation bug fixed.

dapper91 · Dec 7, 2023 · c6ea241 · c6ea241
1 parent cbe54a0
commit c6ea241
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/pjrpc/server/specs/extractors/pydantic.py b/pjrpc/server/specs/extractors/pydantic.py
@@ -74,7 +74,7 @@ def extract_result_schema(self, method: MethodType) -> Schema:
             description=result_schema.get('description', UNSET),
             deprecated=result_schema.get('deprecated', UNSET),
             required=required,
-            definitions=model_schema.get('definitions', UNSET),
+            definitions=model_schema.get('$defs', UNSET),
         )
 
         return result_schema

diff --git a/tests/server/resources/openapi-1.json b/tests/server/resources/openapi-1.json
@@ -282,7 +282,7 @@
                                                     ]
                                                 },
                                                 "result": {
-                                                    "$ref": "#/components/schemas/Model"
+                                                    "$ref": "#/components/schemas/ResultModel"
                                                 }
                                             },
                                             "required": [
@@ -1221,6 +1221,19 @@
                     "field1",
                     "field3"
                 ]
+            },
+            "ResultModel": {
+                "properties": {
+                    "field1": {
+                        "title": "Field1",
+                        "type": "string"
+                    }
+                },
+                "required": [
+                    "field1"
+                ],
+                "title": "ResultModel",
+                "type": "object"
             }
         }
     },

diff --git a/tests/server/test_openapi.py b/tests/server/test_openapi.py
@@ -53,6 +53,9 @@ class Model(pydantic.BaseModel):
         field2: Optional[int] = 1
         field3: SubModel
 
+    class ResultModel(pydantic.BaseModel):
+        field1: str
+
     class TestError(pjrpc.common.exceptions.JsonRpcError):
         code = 2001
         message = 'test error 1'
@@ -91,7 +94,7 @@ class TestError(pjrpc.common.exceptions.JsonRpcError):
     def method1(ctx, param1: int, param2: Model, param3) -> int:
         pass
 
-    def method2(param1: int, param2) -> Model:
+    def method2(param1: int, param2) -> ResultModel:
         pass
 
     def method3(param1: Optional[float] = None, param2: int = 1) -> Optional[str]: