examples/aio_pika_server.py: Fix example add_user() to not trigger mypy #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is a minor improvement to fix
mypy
of a currently not used RPC endpoint function inexamples/aio_pika_server.py
:Details:
The
add_user()
example inexamples/aio_pika_server.py
is not yet used by the example client, so it can be fixed for
mypy
using
dataclasses
similar to the exampleadd_user()
with dataclasses at the end of README.rst:
https://github.com/dapper91/pjrpc/blob/master/README.rst#open-api-specification
@dapper91: The 1st commit of this branch is the commit from #89 as it's context depends on it.
It can be merged after (or instead of) #89.
It reduces the coverage percentage very slightly because the updated lines in the unused function is not yet covered. If this is approved or merged, a test case covering using RabbitMQ in the github actions: