Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy profiles pallet to parachain #62

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

F3Joule
Copy link
Member

@F3Joule F3Joule commented Jun 2, 2022

Based on: #61

Copy link
Contributor

@TarekkMA TarekkMA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pallet is copied exactly from solochain.

@@ -109,27 +109,46 @@ impl<AccountId> User<AccountId> {

#[derive(Encode, Decode, RuntimeDebug)]
pub enum Error {
/// Account is blocked in a given space.
AccountIsBlocked,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the error should be more specific?
For example: AccountIsBlockedInSpace

/// Account is blocked in a given space.
AccountIsBlocked,
/// Content is blocked in a given space.
ContentIsBlocked,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the error should be more specific?
For example: ContentIsBlockedInSpace

pallets/parachain-utils/src/lib.rs Outdated Show resolved Hide resolved
pallets/spaces/src/types.rs Outdated Show resolved Hide resolved
pallets/spaces/src/types.rs Outdated Show resolved Hide resolved
@F3Joule F3Joule marked this pull request as ready for review June 16, 2022 09:16
@F3Joule F3Joule merged commit f163cda into dappforce:feature/move-pallets Jun 16, 2022
@F3Joule F3Joule deleted the f3/move-profiles branch June 24, 2022 13:25
@F3Joule F3Joule mentioned this pull request Jul 4, 2022
25 tasks
@F3Joule F3Joule linked an issue Jul 6, 2022 that may be closed by this pull request
25 tasks
@F3Joule F3Joule removed a link to an issue Jul 6, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants