-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract spaces tests from integration-test #80
Merged
F3Joule
merged 73 commits into
dappforce:feature/tests-and-benchmarks
from
TarekkMA:tarekkma/space-tests
Dec 27, 2022
Merged
Extract spaces tests from integration-test #80
F3Joule
merged 73 commits into
dappforce:feature/tests-and-benchmarks
from
TarekkMA:tarekkma/space-tests
Dec 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
- Add User structure to parachain-utils - Make df-traits crate compilable
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
Add throw_utils_error
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
Integration tests from solochain
…rt` (dappforce#78) * Reactor utils and traits to subsocial-support crate * Fix imports in integration tests * Do a proper name for a crate * Fix Error enum in subsocial-support * Fix runtime * Change SpacePermissionsProvider fn name From `get_space` to `space_permissions_info` * Split `Error` in subsocial-support to a few enums * Refactor `Content` struct Remove `Hyper, rename `Raw` to `Other` * Fix strum dependency in Cargo.toml * Fix integration tests
* Refactor spaces pallet code * Fix code formatting in spaces pallet * Remove handles and scores from spaces * Rename some variables * Fix spaces pallet in a runtime * Fix formatting manually * Fix `init_pallet` in `pallet_spaces`
* Upgrade `pallet-profiles` to the new proc macro * Update Cargo.lock * Fix warnings related to profiles pallet upgrade
Update Cargo.lock
Merge branch dappforce/main into feature/move-pallets
* Fix runtime and errors * Fix integration tests error * Replace social account with space as profile * Fix code formatting * Loose couple profiles with space-ownership - Profiles and space-ownership aren't more tight coupled - Rename `ProfileSpaceByAccount` to `ProfileSpaceIdByAccount` - Add `unset_space_as_profile` extrinsic - Add `ensure_space_owner` to SpacePermissionsProvider * Rename extrinsics in profiles pallet Now two extrinsics to manage profiles are:`set_profile` and `reset_profile`
* Remove redundant counters from space * Fix integration tests
…pforce#111) * WIP: move profile follows pallet from solochain * Update `profile-follows` to the new proc macro * Rename profile-follows to account-follows Add account-follows to runtime
TarekkMA
force-pushed
the
tarekkma/space-tests
branch
from
July 27, 2022 10:41
8b1c1e5
to
c413946
Compare
F3Joule
requested changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove redundant parts of code from tests_utils.rs
and imports from mock.rs
, there are lots of "unused" warnings.
Also, 2 tests are failing here.
F3Joule
approved these changes
Dec 27, 2022
olehmell
approved these changes
Dec 27, 2022
F3Joule
added a commit
that referenced
this pull request
Feb 6, 2023
* Extract post tests from integration-test (#83) Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com> * Extract reaction tests from integration-test (#84) Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com> * Extract space-follows tests from integration-test (#81) Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com> Co-authored-by: Alex Siman <aleksandr.siman@gmail.com> * Extract spaces tests from integration-test (#80) Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com> * Extract space ownership tests from integration-test (#82) Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com> * Clean up Space Ownership tests (#171) * Cleanup mocks and test utils (#172) * Clean up Reactions tests * Clean up Posts tests - Refactor test_utils to correspond with new integration-tests * Clean up Spaces tests --------- Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com> --------- Co-authored-by: Tarek Mohamed Abdalla <tarekkma@gmail.com> Co-authored-by: Alex Siman <aleksandr.siman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #74