Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract space ownership tests from integration-test #82

Merged
merged 75 commits into from
Dec 27, 2022
Merged

Extract space ownership tests from integration-test #82

merged 75 commits into from
Dec 27, 2022

Conversation

TarekkMA
Copy link
Contributor

based on #74

F3Joule and others added 30 commits June 14, 2022 16:30
@F3Joule
WIP: move traits crate from solochain
5c67b72
@F3Joule
WIP: move permissions pallet from solochain
535b4b7
@F3Joule
WIP: Upgrade pallet-permission to the new proc macro
39ed149 
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
@F3Joule
Make permissions pallet compilable
75f1904 
- Add User structure to parachain-utils
- Make df-traits crate compilable
@F3Joule
WIP: move spaces pallet from solochain
99ee08b
@F3Joule
WIP: Upgrade pallet-spaces to the new proc macro
40e8200 
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
@F3Joule
Make spaces pallet compilable
976022a 
Add throw_utils_error
@F3Joule
WIP: move profiles pallet from solochain
f163cda
@F3Joule @siman
Remove profiles struct leaving social account only
2f1e5d6
@F3Joule
WIP: move space-follows pallet from solochain
3544287
@F3Joule
WIP: Upgrade pallet-space-follows to the new proc macro
70db30d 
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
@F3Joule
Make pallet-space-follows compilable
dea202f
@F3Joule
Rearrange pallet-space-follows code
68bc45f
@F3Joule
WIP: move roles pallet from solochain
58ca4a7
@F3Joule
WIP: upgrade pallet-roles to the new proc macro
7857acf 
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
@F3Joule
WIP: make pallet-roles compilable
5ae1a07
@F3Joule
Fix pallet-roles mocks and tests
c927abe
@F3Joule
WIP: Move posts pallet from solochain
84c53f4
@F3Joule
WIP Upgrade pallet-posts to the new proc macro
d91f979 
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
@F3Joule
Make pallet-posts compilable
8e1fd53
@F3Joule
Fix code formatting
9bc2a47
@F3Joule
WIP: move space ownership pallet from solochain
146421e
@F3Joule
WIP Upgrade pallet-space-ownership to the new proc macro
28fc0b2 
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
@F3Joule
Make pallet-space-ownership compilable
a7843f6
@F3Joule
Fix bug with MaxSpacesPerAccount check
86bdd7b
@F3Joule
Rename remove_from_bounded fn
2f992a6
@F3Joule
Fix bug with MaxSpacesPerAccount check
07a1874
@F3Joule
Fix code formatting
23468fc
@F3Joule
WIP: move reactions pallet from solochain
b78fd62
@F3Joule
WIP Upgrade pallet-reactions to the new proc macro
a75cbd0 
Co-Authored-By: Shady Khalifa <shekohex@gmail.com>
F3Joule and others added 14 commits July 8, 2022 16:11
@F3Joule
Refactor pallet-parachain-utils and df-traits to `subsocial-suppo…
8dececb 
…rt` (dappforce#78)

* Reactor utils and traits to subsocial-support crate

* Fix imports in integration tests

* Do a proper name for a crate

* Fix Error enum in subsocial-support

* Fix runtime

* Change SpacePermissionsProvider fn name

From `get_space` to `space_permissions_info`

* Split `Error` in subsocial-support to a few enums

* Refactor `Content` struct

Remove `Hyper, rename `Raw` to `Other`

* Fix strum dependency in Cargo.toml

* Fix integration tests
@F3Joule
Apply fix suggestions to spaces pallet (dappforce#79)
04e70c8 
* Refactor spaces pallet code

* Fix code formatting in spaces pallet

* Remove handles and scores from spaces

* Rename some variables

* Fix spaces pallet in a runtime

* Fix formatting manually

* Fix `init_pallet` in `pallet_spaces`
@F3Joule
Make integration tests compile
dda30cb
@F3Joule
Upgrade pallet-profiles to the new proc macro (dappforce#102)
0655dc0 
* Upgrade `pallet-profiles` to the new proc macro

* Update Cargo.lock

* Fix warnings related to profiles pallet upgrade
@F3Joule
Merge branch dappforce/main into feature/move-pallets
21c283d
@F3Joule
Fix Cargo.toml files after merge
d063ddb 
Update Cargo.lock
@F3Joule
Fix code formatting in permissions pallet
17b9e6e
@TarekkMA
fix pallet_profiles in mocks (dappforce#116)
50b0001
@F3Joule
Merge pull request dappforce#110 from F3Joule/f3/merge-with-main
c542a57 
Merge branch dappforce/main into feature/move-pallets
@F3Joule
Refactor profiles to spaces as profiles (dappforce#106)
9b37441 
* Fix runtime and errors

* Fix integration tests error

* Replace social account with space as profile

* Fix code formatting

* Loose couple profiles with space-ownership

- Profiles and space-ownership aren't more tight coupled
- Rename `ProfileSpaceByAccount` to `ProfileSpaceIdByAccount`
- Add `unset_space_as_profile` extrinsic
- Add `ensure_space_owner` to SpacePermissionsProvider

* Rename extrinsics in profiles pallet

Now two extrinsics to manage profiles are:`set_profile` and `reset_profile`
@F3Joule
Remove redundant counters from Space (dappforce#112)
214c985 
* Remove redundant counters from space

* Fix integration tests
@F3Joule
Merge solochain's profile follows pallet to parachain's profiles (dap…
1018649 
…pforce#111)

* WIP: move profile follows pallet from solochain

* Update `profile-follows` to the new proc macro

* Rename profile-follows to account-follows

Add account-follows to runtime
@TarekkMA
extract space ownership tests from integration-test
3e6140c
@TarekkMA
fix PR
44fd7eb
@TarekkMA TarekkMA force-pushed the tarekkma/space-ownership-tests branch from 3545aaf to 44fd7eb Compare July 27, 2022 11:44
@TarekkMA TarekkMA changed the base branch from feature/move-pallets to main December 20, 2022 08:55
@TarekkMA TarekkMA changed the base branch from main to feature/tests-and-benchmarks December 21, 2022 11:14
@F3Joule F3Joule requested review from olehmell and removed request for siman December 21, 2022 11:40
F3Joule
F3Joule requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@F3Joule F3Joule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant parts of code from tests_utils.rs and imports from mock.rs, there are lots of "unused" warnings.

pallets/space-ownership/tests/Cargo.toml Outdated Show resolved Hide resolved
pallets/space-ownership/tests/Cargo.toml Outdated Show resolved Hide resolved
pallets/space-ownership/tests/Cargo.toml Outdated Show resolved Hide resolved
pallets/space-ownership/tests/Cargo.toml Outdated Show resolved Hide resolved
@F3Joule F3Joule merged commit 5934d90 into dappforce:feature/tests-and-benchmarks Dec 27, 2022
@F3Joule F3Joule removed a link to an issue Feb 3, 2023
Split tests and write benchmarks #87
Closed
12 tasks
F3Joule added a commit that referenced this pull request Feb 6, 2023
@F3Joule @TarekkMA @siman
Move tests to corresponding pallets (#167)
9a311df 
* Extract post tests from integration-test (#83)

Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com>

* Extract reaction tests from integration-test (#84)

Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com>

* Extract space-follows tests from integration-test (#81)

Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com>
Co-authored-by: Alex Siman <aleksandr.siman@gmail.com>

* Extract spaces tests from integration-test (#80)

Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com>

* Extract space ownership tests from integration-test (#82)

Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com>

* Clean up Space Ownership tests (#171)

* Cleanup mocks and test utils (#172)

* Clean up Reactions tests

* Clean up Posts tests
   - Refactor test_utils to correspond with new integration-tests

* Clean up Spaces tests

---------

Co-authored-by: Vlad Proshchavaiev <32250097+F3Joule@users.noreply.github.com>

---------

Co-authored-by: Tarek Mohamed Abdalla <tarekkma@gmail.com>
Co-authored-by: Alex Siman <aleksandr.siman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F3Joule F3Joule F3Joule approved these changes

@olehmell olehmell olehmell approved these changes

Assignees

@TarekkMA TarekkMA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TarekkMA @F3Joule @olehmell