Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: unify version numbers #386

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Changelog

## [Unreleased]
### Changed
- Versions are now for the whole of dapptools, rather than per-tool.
Accordingly, the old CHANGELOG files are superseded by this one.
1 change: 1 addition & 0 deletions VERSION
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1
2 changes: 1 addition & 1 deletion nix/solc-updates.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
1. add a new `solc_X.Y.Z` in the `unreleased` section
1. update `rev` and `sha256` based on the output from `nix-prefetch-git
git@github.com:dapphub/nixpkgs refs/heads/solc-X.Y.Z`
1. bump the version number in `dapp---version`, `src/dapp/default.nix` and the changelog
1. bump the version number in `VERSION` and populate the changelog
1. commit the changes
1. open a pr from `dapphub/dapptools:solc-X.Y.Z` to `dapphub/dapptools:master`
1. once merged tag the commit with the new version number
Expand Down
6 changes: 6 additions & 0 deletions src/seth/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
# Deprecation notice

This file has been deprecated, all future updates will be logged in the
CHANGELOG.md file in the project root.

# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
Expand Down
6 changes: 5 additions & 1 deletion src/seth/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

stdenv.mkDerivation rec {
name = "seth-${version}";
version = "0.8.4";
version = lib.fileContents ../../VERSION;
src = ./.;

nativeBuildInputs = [makeWrapper];
Expand All @@ -18,6 +18,10 @@ stdenv.mkDerivation rec {
else ""}
'';

postFixup = ''
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be postInstall and the current postInstall should be postFixup.

sed -i s/VERSION_PLACEHOLDER/${version}/ $out/libexec/seth/seth---version
'';

meta = {
description = "Command-line client for talking to Ethereum nodes";
homepage = https://github.com/dapphub/dapptools/src/seth/;
Expand Down
6 changes: 3 additions & 3 deletions src/seth/libexec/seth/seth---version
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/usr/bin/env bash
cat <<.
seth 0.8.4
cat <<EOF
seth VERSION_PLACEHOLDER
Copyright (C) 2016, 2017 Daniel Brockman <daniel@dapphub.com>
License: GNU GPL version 3 or later <https://gnu.org/licenses/gpl>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
.
EOF