Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --from-fix command #787

Merged
merged 3 commits into from
Sep 18, 2021
Merged

Add --from-fix command #787

merged 3 commits into from
Sep 18, 2021

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Sep 12, 2021

Description

  • Adds --from-fix command
  • Add --from-fix and --to-fix methods to the docs
  • Fix unrelated typo in seth 4byte-decode

This is a super simple method but let me know if you still want to add tests

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo
Copy link
Contributor

d-xo commented Sep 14, 2021

Could you add some automated tests please 🙏 (this is the file: https://github.com/dapphub/dapptools/blob/master/src/dapp-tests/integration/tests.sh)

@mds1
Copy link
Contributor Author

mds1 commented Sep 15, 2021

@d-xo Done in 8d15eaf

@d-xo d-xo merged commit 59bce78 into dapphub:master Sep 18, 2021
@d-xo
Copy link
Contributor

d-xo commented Sep 18, 2021

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants