seth: non checksum addresses supported in ETH_FROM #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-xo
force-pushed
the
fix-checksum-lookup
branch
2 times, most recently
from
60f8f50
to
da7f49e
Compare
Fixes an issue in #771, where if `ETH_RPC_ACCOUNTS` was set, and `ETH_FROM` was not a checksummed address, the signing request would be incorrectly forwarded to the rpc node, even if `ETH_FROM` was present in a local keystore. The issue is fixed by using a case insensitive grep when checking if `ETH_FROM` is present in a local keystore.
d-xo
force-pushed
the
fix-checksum-lookup
branch
from
da7f49e
to
d368154
Compare
d-xo
commented
Sep 15, 2021
MrChico
reviewed
Sep 15, 2021
| @@ -49,10 +49,52 @@ dapp_testnet() { | |||
|
|
|||
| # dynamic fee transaction (EIP-1559) | |||
| seth send "$A_ADDR" "on()" --gas 0xffff --password /dev/null --from "$ACC" --keystore "$TMPDIR"/8545/keystore --prio-fee 2gwei --gas-price 10gwei | |||
|
|
|||
| # clean up | |||
| killall geth | |||
There was a problem hiding this comment.
don't you wanna do the same thing thats in the trap?
https://github.com/dapphub/dapptools/pull/796/files#diff-f18f8b69e1e1cfa0cc72e097dec217d074ca723df9a72f22f7c997e39ceb8100R6
There was a problem hiding this comment.
Somehow this broke mktemp in the subsequent tests. Not sure why. I redid the dapp testnet stuff in #797 anyway.
gakonst
approved these changes
Sep 16, 2021
|
|
||
| dapp testnet --dir "$TMPDIR" & | ||
| # give it a few secs to start up | ||
| sleep 180 |
There was a problem hiding this comment.
FYI, you can make this like 3-10 seconds and it still works well enough. Should make CI faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in #771, where if
ETH_RPC_ACCOUNTSwas set, andETH_FROMwas not a checksummed address, the signing request would be incorrectly forwarded to the rpc node, even ifETH_FROMwas present in a local keystore.The issue is fixed by using a case insensitive grep when checking if
ETH_FROMis present in a local keystore.Checklist