Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix create with 1559 bug #799

Merged
merged 3 commits into from
Sep 20, 2021
Merged

fix create with 1559 bug #799

merged 3 commits into from
Sep 20, 2021

Conversation

MrChico
Copy link
Member

@MrChico MrChico commented Sep 17, 2021

Description

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@MrChico MrChico marked this pull request as ready for review September 17, 2021 09:30
d-xo
d-xo approved these changes Sep 18, 2021
View reviewed changes
Copy link
Contributor

@d-xo d-xo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really understand why the fix works, but the test passes so lgtm I guess

src/ethsign/ethsign.go
@@ -398,7 +398,7 @@ func main() {
} else if txtype == types.DynamicFeeTxType {
tx = types.NewTx(&types.DynamicFeeTx{
Nonce: nonce,
To: &common.Address{},
To: nil,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what the difference is

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @hexonaut err report I'm guessing common.Address{} is the zero address, which is not the same as not having an address which is needed for creates. There was a comment in geth that led me to believe this is the rught way to do it, and it seems to work in the test

Copy link
Contributor

@d-xo d-xo Sep 19, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok yeah. I can also see this reading through the signer code in geth (e.g. here).

@MrChico MrChico merged commit 5cd96ed into master Sep 20, 2021
@MrChico MrChico deleted the 1559create branch September 20, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-xo d-xo d-xo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MrChico @d-xo