Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polygon Support #853

Merged
merged 9 commits into from
Nov 5, 2021
Merged

Add Polygon Support #853

merged 9 commits into from
Nov 5, 2021

Conversation

ncitron
Copy link
Contributor

@ncitron ncitron commented Nov 4, 2021

Description

Add Polygon support for seth chain, seth etherscan-source, and dapp verify-contract. Please let me know how I should update the changelog as well as I am not too sure about that.

Also, it appears that for most chains, seth etherscan-source is broken. This is because most of the ETHERSCAN_API_URL set at the seth entrypoint has the /api portion included, but seth etherscan-source expects it to not be included. This is breaking my Polygon integration, as well as several others (I tested myself to confirm that it does not work for mainnet or kovan too but I beleive all but arbitrum are broken). Am I misunderstanding something here? I'd be happy to open a new PR to fix it.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@MrChico
Copy link
Member

MrChico commented Nov 5, 2021

Amazing, thanks!

@MrChico MrChico merged commit 0a4c459 into dapphub:master Nov 5, 2021
@d-xo
Copy link
Contributor

d-xo commented Nov 9, 2021

Also, it appears that for most chains, seth etherscan-source is broken. This is because most of the ETHERSCAN_API_URL set at the seth entrypoint has the /api portion included, but seth etherscan-source expects it to not be included. This is breaking my Polygon integration, as well as several others (I tested myself to confirm that it does not work for mainnet or kovan too but I beleive all but arbitrum are broken). Am I misunderstanding something here? I'd be happy to open a new PR to fix it.

Yeah this seems to be a valid bug, a pr to fix it would be very welcome :)

@pyk pyk mentioned this pull request Nov 13, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants