Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate #860

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Release candidate #860

merged 4 commits into from
Nov 15, 2021

Conversation

jennypollack
Copy link
Contributor

Description

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo
Copy link
Contributor

d-xo commented Nov 12, 2021

lgtm. As we discussed in chat, I would probably merge all the commits into one, and then tag that same commit four times to avoid the situation we had last release with inconcistent version numbers in the release picked by the dapptools installer.

@MrChico
Copy link
Member

MrChico commented Nov 13, 2021

why multiple tags? Wouldn't that cause multiple releases?

@d-xo
Copy link
Contributor

d-xo commented Nov 13, 2021

Don't we normally do one release for each tool?

@MrChico
Copy link
Member

MrChico commented Nov 14, 2021

there's not so much point in doing that

@d-xo
Copy link
Contributor

d-xo commented Nov 14, 2021

sure, I agree, but if we want to have one version for all tools we need to implement a new version numbering scheme and I don't think it's worth blocking this release to figure that out, or did you have something else in mind?

@MrChico
Copy link
Member

MrChico commented Nov 14, 2021

no, I don't think we need to change version numbers either. What I'm saying is that right now we are usually bumping all of the numbers at the same time, making one tag, and therefore one release. At least thats what I've been doing. The install scripts always use the latest release anyway, so it's not like ppl are gonna get the different tools from the different releases

@d-xo
Copy link
Contributor

d-xo commented Nov 15, 2021

Ah I see what you mean now. Actually I always tagged each version of each tool separately when I cut a release, but I guess a single tag is fine too 🤷‍♀️

@jennypollack jennypollack merged commit df5fef8 into master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants