fix: loading state does not work with syncing empty collection #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #238
This ports the changes from this suggested patch of rxfire.
This fix only works when
includeMetadataChanges
isfalse
. Whentrue
thencollectionChanges
is used directly and as such requires the suggested patch of rxfire to work around.I've had a go at adding a test which seems to prove that there is no emission on an empty collection without this change, and as such the test fails with a timeout. Not sure if there is a neater way to avoid failing on a timeout and actually asserting on the store loading state.