-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add app channel address flag for run #1283
add app channel address flag for run #1283
Conversation
Codecov Report
@@ Coverage Diff @@
## release-1.11 #1283 +/- ##
=============================================
Coverage 26.87% 26.87%
=============================================
Files 39 39
Lines 3873 3873
=============================================
Hits 1041 1041
Misses 2758 2758
Partials 74 74
|
utils/utils.go
Outdated
@@ -48,6 +48,9 @@ const ( | |||
|
|||
windowsOsType = "windows" | |||
homeDirPrefix = "~/" | |||
|
|||
// DefaultChannelAddress is the default local network address that user application listen on. | |||
DefaultChannelAddress = "127.0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that this is likely to change, but can this be used from the dapr/dapr package? Its already defined there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible I do not want to create another dependency in runtime. Can we move certain constants to kit and let both runtime and CLI depend on that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the issue with adding a package from dapr/dapr
? In Go, as long as you don't have code inside internal
, it's perfectly fine to use it from other referenced code. This ensures we have consistency and not minimize chances of non-synced changes. If anything, I would advocate for the CLI to rely on dapr/dapr
packages as much as it possibly can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing github.com/dapr/pkg/runtime
into utils.go for using the constant defined there started creating issue wrt duplicate protobuf registration https://github.com/dapr/cli/actions/runs/5129434834/jobs/9227056977 associated commit 0381466
for now hardcoding that constant to 127.0.0.1 directly in CLI itself.
69435fd
to
a75d5c9
Compare
Please also update the README file with an example. |
I am also writing an E2E for the same ... will do it |
4a94f94
to
2807011
Compare
Added as part of usage help. |
Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
060f159
to
83ea992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: