Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dapr download speed. #611

Merged
merged 5 commits into from
Aug 19, 2021

Conversation

Fabian-Schmidt
Copy link
Contributor

Description

Remove PowerShell download progress to improve download speed greatly.
With progress bar download speed is around 2-3MBit. Without it download is line limit.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #611 (f1923d7) into master (56cfe97) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   20.73%   20.73%           
=======================================
  Files          29       29           
  Lines        1476     1476           
=======================================
  Hits          306      306           
  Misses       1133     1133           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cfe97...f1923d7. Read the comment docs.

@mukundansundar
Copy link
Collaborator

@ Fabian-Schmidt Can you explain as to why removing the progress bar would affect the transfer speed?

@Fabian-Schmidt
Copy link
Contributor Author

@mukundansundar Please see PowerShell/PowerShell#2138

@yaron2
Copy link
Member

yaron2 commented May 8, 2021

@mukundansundar please review

@mukundansundar mukundansundar requested review from a team as code owners August 18, 2021 02:15
@artursouza artursouza merged commit bd39e6f into dapr:master Aug 19, 2021
@artursouza artursouza modified the milestones: 1.5, v1.4 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants