Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication to GitHub API using GITHUB_TOKEN environment variable #700

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

pkedy
Copy link
Member

@pkedy pkedy commented Apr 27, 2021

Description

Authenticating to the Github API using the GITHUB_TOKEN environment variable, if set.

See https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting

Issue reference

Related to #677 - resolves for our Github Actions Workflow pipeline.

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #700 (ee4f37c) into master (81c88e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   19.79%   19.79%           
=======================================
  Files          28       28           
  Lines        1364     1364           
=======================================
  Hits          270      270           
  Misses       1061     1061           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c88e6...ee4f37c. Read the comment docs.

Copy link
Contributor

@wcs1only wcs1only left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcs1only wcs1only merged commit 49e6654 into dapr:master Apr 27, 2021
@pkedy pkedy deleted the github_api_token_auth branch April 27, 2021 22:16
@mukundansundar mukundansundar added this to the v1.2 milestone May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants