Skip to content

Commit

Permalink
Merge branch 'main' into feature/expand-pulsar-tls-configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
yaron2 committed May 16, 2024
2 parents 9ebd09f + 70fd16a commit c20651a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions bindings/azure/eventhubs/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ builtinAuthenticationProfiles:
entity management is enabled.
metadata:
# Input-only metadata
# consumerGroup is an alias for consumerId, if both are defined consumerId takes precedence.
- name: consumerId
# consumerGroup is an alias for consumerID, if both are defined consumerID takes precedence.
- name: consumerID
type: string
required: true # consumerGroup is an alias for this field, let's promote this to default
binding:
Expand All @@ -108,7 +108,7 @@ metadata:
output: false
description: |
The name of the Event Hubs Consumer Group to listen on.
Alias to consumerId.
Alias to consumerID.
example: '"group1"'
deprecated: true
- name: storageAccountKey
Expand Down
2 changes: 1 addition & 1 deletion pubsub/azure/eventhubs/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ metadata:
description: |
Storage container name.
example: '"myeventhubstoragecontainer"'
- name: consumerId
- name: consumerID
type: string
required: true # consumerGroup is an alias for this field, let's promote this to default
description: |
Expand Down
2 changes: 1 addition & 1 deletion pubsub/rabbitmq/rabbitmq.go
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ func (r *rabbitMQ) subscribeForever(ctx context.Context, req pubsub.SubscribeReq

msgs, err = channel.Consume(
q.Name,
queueName, // consumerId
queueName, // consumerID
r.metadata.AutoAck, // autoAck
false, // exclusive
false, // noLocal
Expand Down

0 comments on commit c20651a

Please sign in to comment.