Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kafka for Pub-Sub #8

Closed
yaron2 opened this issue Sep 27, 2019 · 11 comments
Closed

Add Kafka for Pub-Sub #8

yaron2 opened this issue Sep 27, 2019 · 11 comments

Comments

@yaron2
Copy link
Member

yaron2 commented Sep 27, 2019

No description provided.

@robertojrojas
Copy link
Contributor

@yaron2 I'm going to work on this issue and I was planning to use the Sarama package.

@yaron2
Copy link
Member Author

yaron2 commented Oct 22, 2019

Thats great, thanks!

@yaron2
Copy link
Member Author

yaron2 commented Oct 31, 2019

@robertojrojas are you actively working on this?

@robertojrojas
Copy link
Contributor

@yaron2 yes, I'm hoping to PR in the next day or so.

@yaron2
Copy link
Member Author

yaron2 commented Oct 31, 2019

That's great. No worries, just checking :)

robertojrojas added a commit to robertojrojas/components-contrib that referenced this issue Nov 2, 2019
robertojrojas added a commit to robertojrojas/components-contrib that referenced this issue Nov 2, 2019
@robertojrojas
Copy link
Contributor

@yaron2 Any suggestions on how to integration test the pubsub component?

@yaron2
Copy link
Member Author

yaron2 commented Nov 3, 2019

Add the following line at the bottom of go.mod in the dapr repo:
replace github.com/dapr/components-contrib => ../components-contrib

This assumes your modified components-contrib code resides in the same directory that has the dapr repo in it.

Open a terminal in the dapr repo and run go mod vendor.

This should pull all the dependencies including components-contrib from your local copy into dapr.

Then, update the loader in the Dapr runtime under /pkg/components/pubsub/loader.go:

import "github.com/dapr/components-contrib/pubsub/kafka"

RegisterMessageBus("kafka", kafka.NewKafka)

You can then build the daprd binary locally, copy it to your PATH and test it with the pub-sub sample

@robertojrojas
Copy link
Contributor

@yaron2 Thanks for the instructions.

@rohits-dev
Copy link

quite interested in having a look at kafka pub sub, just wanted to know would it support Schema registry for AVRO schema?

@msfussell msfussell added the P2 label Apr 17, 2020
@khous khous mentioned this issue Apr 22, 2020
3 tasks
yaron2 added a commit that referenced this issue Apr 28, 2020
* fixes issue #8: adds kafka as pubsub component

* fixes issue #8: adds kafka as pubsub component

* pubsub kafka: modifies readme

* pubsub kafka: fixes bug

* pubsub kafka: fixes bug

* pubsub kafka: changes are per PR review

* changes as PR review

* removed unused field

* only close channel once

* working kafka pubsub

* add testing for metadata parsing

* linting

* remove unused PublishTopic, remove loglevel

* Use one consumer group for subscriptions

Co-authored-by: Roberto J Rojas <robertojrojas@gmail.com>
Co-authored-by: Yaron Schneider <yaronsc@microsoft.com>
Co-authored-by: Young Bu Park <youngp@microsoft.com>
Co-authored-by: Aman Bhardwaj <amanbha@users.noreply.github.com>
@yaron2 yaron2 closed this as completed Feb 18, 2021
@mihaimyh
Copy link

Is AVRO schema registry supported?

@mukundansundar
Copy link
Contributor

Is AVRO schema registry supported?

@mihaimyh please create a separate issue for this question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants