Add pubsub support for kafka #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yaron2
requested changes
Apr 23, 2020
yaron2
requested changes
Apr 24, 2020
|
Change looks good, @khous. Have you tested this in any way? |
Yes I have. Here's the integration test I'm relying on I also used one of the sample projects to manually test the functionality. I swapped out redis in the 4.pub-sub sample |
|
Please finish off by updating the docs here: https://github.com/dapr/docs/tree/master/howto/setup-pub-sub-message-broker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add kafka binding for pubsub
Issue reference
#8
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
I have an e2e test which runs just the pubsub functions against kafka. Need to figure out the best way to integrate this. The current e2e tests don't appear to support testing multiple pubsub components, but I might be mistaken.