added binding AWS SES #1021
added binding AWS SES #1021
Conversation
| // Create an SES instance | ||
| svc := ses.New(sess) | ||
|
|
||
| body, err := strconv.Unquote(string(req.Data)) |
There was a problem hiding this comment.
Why unquote? Is this a JSON String? If so, use JSON deserializer instead, so it can handle escaped quotes inside the string correctly.
There was a problem hiding this comment.
In SMTP and sendgrid binding it's used Unquoted method.
Must I change it?
There was a problem hiding this comment.
@artursouza did you see my comment?
There was a problem hiding this comment.
I checked and Unquote() will handle properly escaped quotes too: https://play.golang.org/p/LQHgvD9nZil
|
@fjvela ping |
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
- Coverage 34.53% 34.12% -0.41%
==========================================
Files 132 134 +2
Lines 10870 11146 +276
==========================================
+ Hits 3754 3804 +50
- Misses 6736 6950 +214
- Partials 380 392 +12
Continue to review full report at Codecov.
|
* added binding AWS SES * binding AWS SES: removed unused code * binding AWS SES: fix lint * binding AWS SES: fix parse session token * binding AWS SES: support multiple email && fix cc / bcc parse error * binding AWS S3: add TODO configuration set * binding AWS SES: handle error on unquote req.Data * binding AWS SES: fix lint errors * binding AWS SES: reuse SES instance Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Yaron Schneider <yaronsc@microsoft.com>
Description
New binding AWS SES
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1019
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: