fix when consul is used as a name resolution component problem #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d cannot achieve load balancing, and the dapr started later will overwrite the previous dapr problem
berndverst
reviewed
Apr 18, 2022
| @@ -501,7 +501,7 @@ func TestGetConfig(t *testing.T) { | |||
| assert.Equal(t, 1, len(actual.Registration.Checks)) | |||
| check := actual.Registration.Checks[0] | |||
| assert.Equal(t, "Dapr Health Status", check.Name) | |||
| assert.Equal(t, "daprHealth:test-app", check.CheckID) | |||
There was a problem hiding this comment.
why are you commenting out this test? Please provide a new test for your change instead if this test isn't compatible with your change.
berndverst
requested changes
Apr 18, 2022
|
Please fix the linter issues. |
shubham1172
reviewed
Apr 21, 2022
| Interval: "15s", | ||
| HTTP: fmt.Sprintf("http://%s:%s/v1.0/healthz", host, httpPort), | ||
| DeregisterCriticalServiceAfter: "10m", |
There was a problem hiding this comment.
Should this be configurable? (with a sane default in place)
|
ping @shiling02404. |
|
ping @shiling02404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please reference the issue this PR will close:
#1513
#1199