-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kafka aws iam auth profile #3240
Conversation
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
@amimimor can you please help review this PR? |
Regarding this issue and associated pull request, @yaron2 and I are currently discussing the proposed implementation, which depends on the AWS Go SDK version 2 library directly and indirectly. AFAIK, the Components ecosystem for this project has not yet migrated to using version 2 of the AWS Go SDK. We need to evaluate whether now is the appropriate time to introduce a dependency on v2, or if we should consider alternative implementations that are compatible with the v1 SDK that is currently used across components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note, for future reference that this is the first time the project uses AWS Go SDK v2 module (while the rest of the project uses v1)
@famarting please check the failing checks, specifically the build check and the Kafka pubsub certification test |
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
ced78a1
to
d7dee43
Compare
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
5c33176
to
82f0a6e
Compare
@famarting please follow up with docs. |
Description
Adds support for the authType
awsIAM
to the kafka componentsIssue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #3239
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: