Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka aws iam auth profile #3240

Merged
merged 7 commits into from
Dec 12, 2023
Merged

kafka aws iam auth profile #3240

merged 7 commits into from
Dec 12, 2023

Conversation

famarting
Copy link
Contributor

Description

Adds support for the authType awsIAM to the kafka components

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3239

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
@famarting famarting requested review from a team as code owners November 20, 2023 11:15
@yaron2
Copy link
Member

yaron2 commented Nov 21, 2023

@amimimor can you please help review this PR?

@amimimor
Copy link
Contributor

Regarding this issue and associated pull request, @yaron2 and I are currently discussing the proposed implementation, which depends on the AWS Go SDK version 2 library directly and indirectly. AFAIK, the Components ecosystem for this project has not yet migrated to using version 2 of the AWS Go SDK.

We need to evaluate whether now is the appropriate time to introduce a dependency on v2, or if we should consider alternative implementations that are compatible with the v1 SDK that is currently used across components.

Copy link
Contributor

@amimimor amimimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note, for future reference that this is the first time the project uses AWS Go SDK v2 module (while the rest of the project uses v1)

@yaron2
Copy link
Member

yaron2 commented Dec 11, 2023

@famarting please check the failing checks, specifically the build check and the Kafka pubsub certification test

Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
@yaron2
Copy link
Member

yaron2 commented Dec 12, 2023

@famarting please follow up with docs.

@yaron2 yaron2 added this pull request to the merge queue Dec 12, 2023
Merged via the queue into dapr:main with commit 7c80133 Dec 12, 2023
86 checks passed
@ItalyPaleAle ItalyPaleAle added this to the v1.13 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS IAM Authentication for Kafka components
4 participants