Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka: Support for AWS IAM role auth #3310

Merged
merged 8 commits into from
Jan 10, 2024
Merged

Conversation

eunicecompra
Copy link
Contributor

Description

Follow up of the #3240

This is to add an AWS IAM role authentication aside from AWS credentials.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3239 (Already closed but related issue)

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@eunicecompra eunicecompra requested review from a team as code owners January 9, 2024 21:47
@eunicecompra eunicecompra changed the title Kafka aws iam role Kafka: Support for AWS IAM role auth Jan 9, 2024
ItalyPaleAle
ItalyPaleAle previously approved these changes Jan 9, 2024
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @yaron2 can you please review too

@ItalyPaleAle
Copy link
Contributor

@eunicecompra can you please fix the DCO?
https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work

Eunice Compra and others added 6 commits January 10, 2024 09:35
Signed-off-by: Eunice Compra <eunicecompra@gmail.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Bernd Verst <github@bernd.dev>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Eunice Compra <eunicecompra@gmail.com>
@eunicecompra eunicecompra dismissed ItalyPaleAle’s stale review January 9, 2024 22:48

The merge-base changed after approval.

@eunicecompra
Copy link
Contributor Author

@eunicecompra can you please fix the DCO? https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work

@ItalyPaleAle Missed this one. Done signing off my commits.

@yaron2 yaron2 enabled auto-merge January 10, 2024 03:45
@yaron2 yaron2 added this pull request to the merge queue Jan 10, 2024
Merged via the queue into dapr:main with commit 85722a4 Jan 10, 2024
86 of 89 checks passed
@eunicecompra eunicecompra deleted the kafka-aws-iam-role branch January 10, 2024 22:35
toneill818 pushed a commit to toneill818/components-contrib that referenced this pull request Jan 22, 2024
Signed-off-by: Eunice Compra <eunicecompra@gmail.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Eunice Compra <eunice.compra@gmail.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Bernd Verst <github@bernd.dev>
Co-authored-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: Thomas O'Neill <toneill@new-innov.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS IAM Authentication for Kafka components
4 participants