Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL Server state store not working with case-sensitive collations #3272

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ItalyPaleAle
Copy link
Contributor

Fixes #3271

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle requested review from a team as code owners December 14, 2023 18:27
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a6710b9) 34.91% compared to head (a7352bf) 34.91%.

Files Patch % Lines
state/sqlserver/migration.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.12    #3272   +/-   ##
=============================================
  Coverage         34.91%   34.91%           
=============================================
  Files               241      241           
  Lines             29927    29927           
=============================================
  Hits              10449    10449           
  Misses            18594    18594           
  Partials            884      884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ItalyPaleAle ItalyPaleAle merged commit 3dc465e into dapr:release-1.12 Dec 14, 2023
92 of 93 checks passed
@ItalyPaleAle ItalyPaleAle deleted the fix-3271 branch December 14, 2023 23:14
ItalyPaleAle added a commit to ItalyPaleAle/dapr-components-contrib that referenced this pull request Dec 14, 2023
…dapr#3272)

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle added a commit to ItalyPaleAle/dapr-components-contrib that referenced this pull request Dec 15, 2023
…llation

The fix in dapr#3272 allowed support for case-sensitive database collations, but wasn't enough for server collations

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
yaron2 pushed a commit that referenced this pull request Dec 18, 2023
…ion (#3276)

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle added a commit that referenced this pull request Dec 18, 2023
…ion (#3276)

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants