Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka: Removed the AWS creds check from kafka metadata #3313

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Kafka: Removed the AWS creds check from kafka metadata #3313

merged 1 commit into from
Jan 10, 2024

Conversation

eunicecompra
Copy link
Contributor

@eunicecompra eunicecompra commented Jan 10, 2024 •
edited
Loading

Description

This is a follow-up PR based on the comment #3310 (comment)

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@eunicecompra
removed the aws creds check from kafka metadata
048beed 
Signed-off-by: Eunice Compra <eunicecompra@gmail.com>
@eunicecompra eunicecompra requested review from a team as code owners January 10, 2024 22:36
@eunicecompra
Copy link
Contributor Author

@famarting @yaron2 For your review

yaron2
yaron2 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick correction

@yaron2 yaron2 enabled auto-merge January 10, 2024 22:59
@yaron2 yaron2 added this pull request to the merge queue Jan 10, 2024
Merged via the queue into dapr:main with commit e524ae7 Jan 10, 2024
87 of 88 checks passed
@eunicecompra eunicecompra deleted the kafka-remove-aws-creds-check branch January 10, 2024 23:42
toneill818 pushed a commit to toneill818/components-contrib that referenced this pull request Jan 22, 2024
@eunicecompra @toneill-newinnov
Kafka: Removed the AWS creds check from kafka metadata (dapr#3313)
bcfb5b4 
Signed-off-by: Eunice Compra <eunicecompra@gmail.com>
Co-authored-by: Eunice Compra <eunice.compra@gmail.com>
Signed-off-by: Thomas O'Neill <toneill@new-innov.com>
@yaron2 yaron2 added this to the v1.13 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaron2 yaron2 yaron2 approved these changes

Assignees

@eunicecompra eunicecompra

Labels
None yet
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eunicecompra @yaron2