Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 add storage class to metadata #3369

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

nadavv169
Copy link
Contributor

@nadavv169 nadavv169 commented Feb 28, 2024

Description

Added support to define storage class while using the create operation in AWS S3 binding.
To use it we need to pass the storageClass field to the binding_metadata at the create operation, like the PresignTTL metadata.

For example:
curl -d '{ "operation": "create", "data": "YOUR_BASE_64_CONTENT", "metadata": { "storageClass": "STANDARD_IA" } }' http://localhost:<dapr-port>/v1.0/bindings/<binding-name>

Or using the Python SDK:
response = client.invoke_binding("s3binding", "create", data="some data", binding_metadata={"storageClass": "STANDARD_IA"})

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: nadavv169 <nadavv169@gmail.com>
Signed-off-by: nadavv169 <nadavv169@gmail.com>
Signed-off-by: nadavv169 <nadavv169@gmail.com>
@nadavv169 nadavv169 requested review from a team as code owners February 28, 2024 16:50
@ItalyPaleAle ItalyPaleAle merged commit 49afc55 into dapr:main Feb 28, 2024
86 of 89 checks passed
@ItalyPaleAle
Copy link
Contributor

Thank you @nadavv169 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants