Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to generate signed url in gcp bucket #3393

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

bhagya05
Copy link
Contributor

@bhagya05 bhagya05 commented Apr 9, 2024

Description

Added ability to generate signed url from GCP bucket

Issue reference

Please reference the issue this PR will close: #2862

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: bhagya05 <bhagyasingh05@gmail.com>
@bhagya05 bhagya05 requested review from a team as code owners April 9, 2024 12:21
Signed-off-by: bhagya05 <bhagyasingh05@gmail.com>
@yaron2
Copy link
Member

yaron2 commented May 14, 2024

@bhagya05 can you please add the signTTL metadata item here? https://github.com/dapr/components-contrib/blob/main/bindings/gcp/bucket/metadata.yaml

Signed-off-by: bhagya05 <bhagyasingh05@gmail.com>
@bhagya05
Copy link
Contributor Author

@yaron2 Done

@yaron2 yaron2 enabled auto-merge June 11, 2024 14:45
@yaron2
Copy link
Member

yaron2 commented Jun 11, 2024

@bhagya05 Please open a docs issue to update the GCP binding with this new metadata option. Thank you for this contribution!

@yaron2 yaron2 disabled auto-merge June 12, 2024 06:17
@yaron2 yaron2 merged commit 105dabb into dapr:main Jun 12, 2024
87 of 91 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @bhagya05 Enjoy the Dapr components badge!

Copy link

holopin-bot bot commented Jun 17, 2024

Congratulations @bhagya05, you just earned a badge! Here it is: https://holopin.io/claim/clxj3rtdf08270cl5hjb0yt7r

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable signed url in GCP Storage Bucket
3 participants