Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for s3 list object versions operation in s3 binding #3465

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nenikola
Copy link
Contributor

Description

Added new operation support within the s3 binding for listing an object's versions

Issue reference

Solves an AWS part of #3426

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@nenikola nenikola requested review from a team as code owners June 26, 2024 19:04
@berndverst
Copy link
Member

FYI, this PR was opened after our 1.14 code freeze unfortunately. So we likely cannot include it in 1.14 which we are in the process of releasing at the moment.

@@ -389,6 +392,32 @@ func (s *AWSS3) list(ctx context.Context, req *bindings.InvokeRequest) (*binding
}, nil
}

func (s *AWSS3) listObjectVersions(ctx context.Context, req *bindings.InvokeRequest) (*bindings.InvokeResponse, error) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: no newline here please

@berndverst
Copy link
Member

berndverst commented Jul 2, 2024

Please sign off on your commits.

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~3 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin support-list-object-versions-s3-operation

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants