Rename JSONSecretStore into LocalSecretStore and remove DAPR_ENABLE_JSON_SECRET_STORE envvar #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmendible
force-pushed
the
localsecretstore
branch
from
be73a9b
to
495995b
Compare
amanbha
requested review from
orizohar,
mchmarny,
amanbha,
msfussell,
yaron2 and
youngbupark
youngbupark
changed the title
amanbha
approved these changes
Jun 16, 2020
|
I believe there was a docs PR that was reverted as well. The doc should be merged as well with the new naming |
Yes, I have re-opened this docs issue as wellhttps://github.com/dapr/docs/issues/608 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored JSONSecretStore into LocalSecretStore and removed the use of the DAPR_ENABLE_JSON_SECRET_STORE environment variable as suggested here: dapr/dapr#1633
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #360
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: