-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use concurrency control in Redis store's Multi() #466
Conversation
LGTM. thanks for the cleaning up the code as well. with 0.10.0 dapr
with your change
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please run the backward compat test before merging.
@youngbupark thanks for the instruction. I've confirmed backward compat using that sequence. |
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 28.27% 28.54% +0.27%
==========================================
Files 79 79
Lines 6263 6263
==========================================
+ Hits 1771 1788 +17
+ Misses 4296 4273 -23
- Partials 196 202 +6
Continue to review full report at Codecov.
|
This is to pick up dapr/components-contrib#466
This is to pick up dapr/components-contrib#466
Description
Change
Multi()
to use samesetQuery
anddelQuery
mechanisms asSet()
andDelete()
.Issue reference
Please reference the issue this PR will close: #375
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: