Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests should run with a highly available setup #2188

Closed
yaron2 opened this issue Oct 3, 2020 · 3 comments · Fixed by #2189 or #2192
Closed

E2E tests should run with a highly available setup #2188

yaron2 opened this issue Oct 3, 2020 · 3 comments · Fixed by #2189 or #2192
Assignees
Labels
kind/bug Something isn't working

Comments

@yaron2
Copy link
Member

yaron2 commented Oct 3, 2020

Today, end to end tests run the non-production recommended setup with one instance per pod.

As between the two modes (non-HA and HA) the highly available setup is both the recommended one and also the more complex one in terms of different coordination between resources on an otherwise no resource dependency coordinated hosting platform (Kubernetes), it's recommended we run the e2e tests with ha.enabled=true.

/cc @youngbupark @msfussell

Release Note

RELEASE NOTE: Added E2E tests option to run in HA mode

@yaron2 yaron2 added the kind/bug Something isn't working label Oct 3, 2020
@youngbupark
Copy link
Contributor

I agree on enable HA mode for the existing e2e tests. For non-HA mode, I would add one more KinD test for non-HA mode. @yaron2 what do you think?

  1. AKS cluster test - HA mode enabled.
  2. KinD test for three k8s versions with HA mode
    **3. Kind test for one version k8s with non-HA mode. ** -> new

cc/ @tcnghia

@tcnghia
Copy link
Member

tcnghia commented Oct 3, 2020

Regarding running HA tests on KinD, I think some experiments will be needed. It would be nice to test HA there if we can fit our tests there.

+1 to leave some coverage for non-HA to ensure a good experience for users trying things out.

@tcnghia
Copy link
Member

tcnghia commented Oct 3, 2020

To clarify the experimentations: currently, our KinD cluster was created with 2 worker nodes. I don't know what our HA test setup looks like, but if we want to have at least 3 control plane Pods on different nodes, then we will need to at least add one more worker Node.

@yaron2 yaron2 self-assigned this Oct 6, 2020
@yaron2 yaron2 added this to To do in 1.0.0 Milestone 1 via automation Oct 6, 2020
@yaron2 yaron2 moved this from To do to Review in 1.0.0 Milestone 1 Oct 6, 2020
@artursouza artursouza moved this from Review to Done in 1.0.0 Milestone 1 Oct 6, 2020
@artursouza artursouza added this to Release in 1.0.0 Milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants