Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make e2e run in HA mode #2189

Merged
merged 5 commits into from Oct 3, 2020
Merged

Make e2e run in HA mode #2189

merged 5 commits into from Oct 3, 2020

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Oct 3, 2020

Do not merge before #2185.

Closes #2188

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #2189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2189   +/-   ##
=======================================
  Coverage   46.26%   46.26%           
=======================================
  Files          69       69           
  Lines        6078     6078           
=======================================
  Hits         2812     2812           
  Misses       3008     3008           
  Partials      258      258           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9518288...495bfb5. Read the comment docs.

@tcnghia
Copy link
Member

tcnghia commented Oct 3, 2020

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 3, 2020

Found the available test cluster - dapr-aks-e2e-07 for linux. Please check the build status.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 3, 2020

Found the available test cluster - dapr-aks-e2e-08 for windows. Please check the build status.

@yaron2
Copy link
Member Author

yaron2 commented Oct 3, 2020

I think the 30s timeout for helm install needs to increase, I've seen the KiND tests timeout when installing.

/cc @youngbupark

@youngbupark
Copy link

youngbupark commented Oct 3, 2020

@yaron2 Once all e2e tests are green, then I will cut 0.11.1 release

cc/ @mchmarny @msfussell @orizohar @yolember

@yaron2
Copy link
Member Author

yaron2 commented Oct 3, 2020

I think the 30s timeout for helm install needs to increase, I've seen the KiND tests timeout when installing.

/cc @youngbupark

Also, I think as @tcnghia mentioned, we need to increase the node size / add nodes.. Pods might be pending.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 3, 2020

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 3, 2020

End-to-end tests failed on windows. Please check the build logs

@youngbupark
Copy link

I think the 30s timeout for helm install needs to increase, I've seen the KiND tests timeout when installing.
/cc @youngbupark

Also, I think as @tcnghia mentioned, we need to increase the node size / add nodes.. Pods might be pending.

helm install \
	dapr --namespace=dapr-tests --wait --timeout 5m0s\
	--set global.ha.enabled=true --set-string global.tag=dev-linux-amd64 --set-string global.registry=localhost:5000/dapr --set global.logAsJson=true --set global.daprControlPlaneOs=linux ./charts/dapr

5 minutes timeout. So it may be because of node size.

@youngbupark
Copy link

/ok-to-test

@yaron2
Copy link
Member Author

yaron2 commented Oct 3, 2020

I think the 30s timeout for helm install needs to increase, I've seen the KiND tests timeout when installing.
/cc @youngbupark

Also, I think as @tcnghia mentioned, we need to increase the node size / add nodes.. Pods might be pending.

helm install \
	dapr --namespace=dapr-tests --wait --timeout 5m0s\
	--set global.ha.enabled=true --set-string global.tag=dev-linux-amd64 --set-string global.registry=localhost:5000/dapr --set global.logAsJson=true --set global.daprControlPlaneOs=linux ./charts/dapr

5 minutes timeout. So it may be because of node size.

Yeah. The pods are probably pending, as helm install times out on KinD.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 3, 2020

Found the available test cluster - dapr-aks-e2e-05 for linux. Please check the build status.

@youngbupark
Copy link

windows e2e test is failed. restarting test.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 3, 2020

Found the available test cluster - dapr-aks-e2e-06 for windows. Please check the build status.

@yaron2
Copy link
Member Author

yaron2 commented Oct 3, 2020

End-to-end tests failed on windows. Please check the build logs

Also, do we know why Windows tests are interminantly failing on the scheduled runs?

https://github.com/dapr/dapr/actions?query=workflow%3Adapr-test

@youngbupark
Copy link

pubsub test failed in windows e2e test. I hope this was just an intermittent failure.

Failed Platform.addApps(), deployment "pubsub-publisher" is not in desired state, received: &Deployment{ObjectMeta:{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []},Spec:DeploymentSpec{Replicas:nil,Selector:nil,Template:{{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []} {[] [] [] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] []}},Strategy:DeploymentStrategy{Type:,RollingUpdate:nil,},MinReadySeconds:0,RevisionHistoryLimit:nil,Paused:false,ProgressDeadlineSeconds:nil,},Status:DeploymentStatus{ObservedGeneration:0,Replicas:0,UpdatedReplicas:0,AvailableReplicas:0,UnavailableReplicas:0,Conditions:[]DeploymentCondition{},ReadyReplicas:0,CollisionCount:nil,},}: etcdserver: request timed out2020/10/03 18:47:08 Running teardown...
FAIL	github.com/dapr/dapr/tests/e2e/pubsub	28.030s
Enter TestMain

@youngbupark
Copy link

I think the 30s timeout for helm install needs to increase, I've seen the KiND tests timeout when installing.
/cc @youngbupark

Also, I think as @tcnghia mentioned, we need to increase the node size / add nodes.. Pods might be pending.

helm install \
	dapr --namespace=dapr-tests --wait --timeout 5m0s\
	--set global.ha.enabled=true --set-string global.tag=dev-linux-amd64 --set-string global.registry=localhost:5000/dapr --set global.logAsJson=true --set global.daprControlPlaneOs=linux ./charts/dapr

5 minutes timeout. So it may be because of node size.

Yeah. The pods are probably pending, as helm install times out on KinD.

Turned off HA for KinD test for now. we can revisit it later. let's see how aks cluster tests go.

@tcnghia
Copy link
Member

tcnghia commented Oct 3, 2020

If it is difficult for the KinD workflows to support HA testing I think we could turn on the HA testing for AKS workflows first. That allows this PR to be checked in early leading to more testing/baking time (through scheduled workflows) before we cut the patch release.

Independently in that time window, we could try turning on the HA testing for KinD workflows.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 3, 2020

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 3, 2020

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

@youngbupark youngbupark self-requested a review October 3, 2020 19:21
@youngbupark youngbupark merged commit 34f5e8d into dapr:master Oct 3, 2020
@youngbupark youngbupark deleted the e2eha branch October 3, 2020 19:22
youngbupark pushed a commit that referenced this pull request Oct 3, 2020
* make e2e run in ha mode

* spacing

* turn off ha for kind

Co-authored-by: Young Bu Park <youngp@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests should run with a highly available setup
4 participants