-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run HA tests on KinD clusters #2192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2192 +/- ##
=======================================
Coverage 46.26% 46.26%
=======================================
Files 69 69
Lines 6078 6078
=======================================
Hits 2812 2812
Misses 3008 3008
Partials 258 258 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently seeing that ha mode is always set to false from the run logs during helm install
--set global.ha.enabled=false
Nice catch! Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This enables the HA tests on our KinD workflows. non-HA mode is still tested on the latest K8s version to ensure we have coverage for users just trying things out and don't have a large cluster.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2188
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: