Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run HA tests on KinD clusters #2192

Merged
merged 4 commits into from
Oct 4, 2020
Merged

Run HA tests on KinD clusters #2192

merged 4 commits into from
Oct 4, 2020

Conversation

tcnghia
Copy link
Member

@tcnghia tcnghia commented Oct 3, 2020

Description

This enables the HA tests on our KinD workflows. non-HA mode is still tested on the latest K8s version to ensure we have coverage for users just trying things out and don't have a large cluster.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #2188

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@tcnghia tcnghia requested review from youngbupark and yaron2 and removed request for youngbupark October 3, 2020 20:44
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #2192 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2192   +/-   ##
=======================================
  Coverage   46.26%   46.26%           
=======================================
  Files          69       69           
  Lines        6078     6078           
=======================================
  Hits         2812     2812           
  Misses       3008     3008           
  Partials      258      258           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b55fb5...67ffa1e. Read the comment docs.

Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently seeing that ha mode is always set to false from the run logs during helm install

--set global.ha.enabled=false

https://github.com/dapr/dapr/pull/2192/checks#step:10:32

@tcnghia
Copy link
Member Author

tcnghia commented Oct 3, 2020

I am currently seeing that ha mode is always set to false from the run logs during helm install

--set global.ha.enabled=false

https://github.com/dapr/dapr/pull/2192/checks#step:10:32

Nice catch! Fixed.

Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tcnghia tcnghia merged commit e5297a7 into dapr:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests should run with a highly available setup
4 participants