-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm install of custom sidecar container image without injector fails #3192
Comments
CodeMonkeyLeet
pushed a commit
to CodeMonkeyLeet/dapr
that referenced
this issue
May 19, 2021
…or chart Fixes dapr#3192 Add a `injectorImage.name` value to the dapr_sidecar_injector deployment template to separate the customization of the image used for the injector service from the existing `image.name` value used to specify the injected sidecar image.
7 tasks
CodeMonkeyLeet
pushed a commit
to CodeMonkeyLeet/dapr
that referenced
this issue
May 19, 2021
…or chart Fixes dapr#3192 Add a `injectorImage.name` value to the dapr_sidecar_injector deployment template to separate the customization of the image used for the injector service from the existing `image.name` value used to specify the injected sidecar image.
@CodeMonkeyLeet Please, comment on this issue so it can be assigned to you. |
/assign |
dapr-bot
added a commit
that referenced
this issue
May 26, 2021
…or chart (#3193) * Use separate custom image for injector service in dapr_sidecar_injector chart Fixes #3192 Add a `injectorImage.name` value to the dapr_sidecar_injector deployment template to separate the customization of the image used for the injector service from the existing `image.name` value used to specify the injected sidecar image. * Clarify default image.names for dapr service helm charts Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
daixiang0
pushed a commit
to daixiang0/dapr
that referenced
this issue
Jun 9, 2021
…or chart (dapr#3193) * Use separate custom image for injector service in dapr_sidecar_injector chart Fixes dapr#3192 Add a `injectorImage.name` value to the dapr_sidecar_injector deployment template to separate the customization of the image used for the injector service from the existing `image.name` value used to specify the injected sidecar image. * Clarify default image.names for dapr service helm charts Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In what area(s)?
/area test-and-release
What version of Dapr?
Expected Behavior
Installing dapr through Helm with a custom sidecar image that does not contain the injector service should succeed.
Actual Behavior
The deployment template for dapr_sidecar_injector uses the same
image.name
value for both the injector service and the injected sidecar, although the documentation suggests that it is only used for the sidecar image. If provided a custom image not containing the injector binary, the helm install fails with the failure to bring up the sidecar injector service:Steps to Reproduce the Problem
Follow the instructions for Install with Helm (advanced) with a helm command to specify a custom daprd sidecar image that does not contain the injector binary.
Release Note
RELEASE NOTE: FIX Helm install of custom sidecar container image without injector fails
The text was updated successfully, but these errors were encountered: