Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm install of custom sidecar container image without injector fails #3192

Closed
CodeMonkeyLeet opened this issue May 19, 2021 · 2 comments · Fixed by #3193
Closed

Helm install of custom sidecar container image without injector fails #3192

CodeMonkeyLeet opened this issue May 19, 2021 · 2 comments · Fixed by #3193
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@CodeMonkeyLeet
Copy link
Contributor

In what area(s)?

/area runtime
/area operator
/area placement
/area docs

/area test-and-release

What version of Dapr?

1.1.x

Expected Behavior

Installing dapr through Helm with a custom sidecar image that does not contain the injector service should succeed.

Actual Behavior

The deployment template for dapr_sidecar_injector uses the same image.name value for both the injector service and the injected sidecar, although the documentation suggests that it is only used for the sidecar image. If provided a custom image not containing the injector binary, the helm install fails with the failure to bring up the sidecar injector service:

NAME                                     READY   STATUS             RESTARTS   AGE
dapr-dashboard-564485bbb7-2qfg8          1/1     Running            0          5m25s
dapr-operator-7f6d6cd94d-blkvp           1/1     Running            0          5m25s
dapr-placement-server-0                  1/1     Running            0          5m25s
dapr-sentry-86dc6d67f-8tw7x              1/1     Running            0          5m25s
dapr-sidecar-injector-55f74945df-xn6qw   0/1     CrashLoopBackOff   5          5m25s

Steps to Reproduce the Problem

Follow the instructions for Install with Helm (advanced) with a helm command to specify a custom daprd sidecar image that does not contain the injector binary.

helm upgrade --install dapr dapr/dapr \
--version=1.1.2 \
--namespace dapr-system \
--create-namespace \
--set dapr_sidecar_injector.image.name=docker.io/daprio/daprd \
--wait

Release Note

RELEASE NOTE: FIX Helm install of custom sidecar container image without injector fails

@CodeMonkeyLeet CodeMonkeyLeet added the kind/bug Something isn't working label May 19, 2021
CodeMonkeyLeet pushed a commit to CodeMonkeyLeet/dapr that referenced this issue May 19, 2021
…or chart

Fixes dapr#3192

Add a `injectorImage.name` value to the dapr_sidecar_injector deployment template to
separate the customization of the image used for the injector service from the
existing `image.name` value used to specify the injected sidecar image.
CodeMonkeyLeet pushed a commit to CodeMonkeyLeet/dapr that referenced this issue May 19, 2021
…or chart

Fixes dapr#3192

Add a `injectorImage.name` value to the dapr_sidecar_injector deployment template to
separate the customization of the image used for the injector service from the
existing `image.name` value used to specify the injected sidecar image.
@artursouza
Copy link
Member

@CodeMonkeyLeet Please, comment on this issue so it can be assigned to you.

@artursouza artursouza added this to the v1.3 milestone May 20, 2021
@CodeMonkeyLeet
Copy link
Contributor Author

/assign

dapr-bot added a commit that referenced this issue May 26, 2021
…or chart (#3193)

* Use separate custom image for injector service in dapr_sidecar_injector chart

Fixes #3192

Add a `injectorImage.name` value to the dapr_sidecar_injector deployment template to
separate the customization of the image used for the injector service from the
existing `image.name` value used to specify the injected sidecar image.

* Clarify default image.names for dapr service helm charts

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
daixiang0 pushed a commit to daixiang0/dapr that referenced this issue Jun 9, 2021
…or chart (dapr#3193)

* Use separate custom image for injector service in dapr_sidecar_injector chart

Fixes dapr#3192

Add a `injectorImage.name` value to the dapr_sidecar_injector deployment template to
separate the customization of the image used for the injector service from the
existing `image.name` value used to specify the injected sidecar image.

* Clarify default image.names for dapr service helm charts

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants