-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate content type for pubsub data. #2493
Conversation
/ok-to-test |
Found the available test cluster - dapr-aks-e2e-05 for linux. Please check the build status. |
5574df7
to
acdd689
Compare
Found the available test cluster - dapr-aks-e2e-06 for windows. Please check the build status. |
Congrats! All end-to-end tests have passed on linux. Thanks for your contribution! |
Codecov Report
@@ Coverage Diff @@
## master #2493 +/- ##
==========================================
- Coverage 57.10% 57.06% -0.05%
==========================================
Files 80 80
Lines 7041 7043 +2
==========================================
- Hits 4021 4019 -2
- Misses 2743 2747 +4
Partials 277 277
Continue to review full report at Codecov.
|
/ok-to-test |
Found the available test cluster - dapr-aks-e2e-07 for linux. Please check the build status. |
Found the available test cluster - dapr-aks-e2e-08 for windows. Please check the build status. |
End-to-end tests failed on windows. Please check the build logs |
Found the available test cluster - dapr-aks-e2e-06 for linux. Please check the build status. |
Congrats! All end-to-end tests have passed on linux. Thanks for your contribution! |
End-to-end tests cancelled on linux. Please check the build logs |
Congrats! All end-to-end tests have passed on windows. Thanks for your contribution! |
@@ -178,6 +178,9 @@ message PublishEventRequest { | |||
|
|||
// The data which will be published to topic. | |||
bytes data = 3; | |||
|
|||
// The content type for the data (optional). | |||
string dataContentType = 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the existing convention. Member naming is snake case, that is what protobuf official guideline recommends. Then Protoc will generate the member based on language it could be camel case or snake case depending on the language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need to fix this. Thanks.
Description
Propagate content type for pubsub data.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2080
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: