Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cloudstate state store #3897

Merged
merged 6 commits into from Nov 19, 2021
Merged

Conversation

CodeMonkeyLeet
Copy link
Contributor

Description

Remove the Cloudstate state store from daprd.

Issue reference

Part of dapr/components-contrib#1297

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@CodeMonkeyLeet CodeMonkeyLeet requested review from a team as code owners November 13, 2021 00:20
yaron2
yaron2 previously approved these changes Nov 13, 2021
Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #3897 (a54c001) into master (59e75aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3897   +/-   ##
=======================================
  Coverage   62.39%   62.39%           
=======================================
  Files         101      101           
  Lines        9506     9506           
=======================================
  Hits         5931     5931           
  Misses       3109     3109           
  Partials      466      466           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e75aa...a54c001. Read the comment docs.

Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge #1303 first then upgrade components-contrib version here, then we can get clean go mod file.

@CodeMonkeyLeet
Copy link
Contributor Author

@artursouza Thanks for the go.mod update!

@daixiang0 This is just blocked on your approval now.

@artursouza artursouza added the automerge Allows DaprBot to automerge and update PR if all approvals are in place label Nov 19, 2021
@artursouza artursouza dismissed daixiang0’s stale review November 19, 2021 18:51

I updated the contrib file.

@artursouza artursouza merged commit 5c0176d into dapr:master Nov 19, 2021
@artursouza artursouza added this to the v1.6 milestone Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allows DaprBot to automerge and update PR if all approvals are in place
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants