Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add middle/http routerchecker #4402

Merged
merged 5 commits into from
Apr 15, 2022
Merged

feature: add middle/http routerchecker #4402

merged 5 commits into from
Apr 15, 2022

Conversation

1046102779
Copy link
Member

Signed-off-by: 1046102779 <seachen@tencent.com>
@1046102779 1046102779 requested review from a team as code owners March 21, 2022 06:30
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #4402 (d5e6a33) into master (0ac20c1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4402   +/-   ##
=======================================
  Coverage   64.81%   64.81%           
=======================================
  Files         109      109           
  Lines       11097    11097           
=======================================
  Hits         7193     7193           
  Misses       3384     3384           
  Partials      520      520           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac20c1...d5e6a33. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yaron2 yaron2 merged commit b298e16 into dapr:master Apr 15, 2022
@yaron2
Copy link
Member

yaron2 commented Apr 15, 2022

@1046102779 thanks for this PR and apologies we couldn't get this into 1.7. This will now be released in 1.8.

@yaron2 yaron2 added this to the v1.8 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants