Fix: Helm dapr upgrade #5794
Merged
Fix: Helm dapr upgrade #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov Report
@@ Coverage Diff @@
## master #5794 +/- ##
==========================================
- Coverage 65.35% 65.33% -0.02%
==========================================
Files 150 150
Lines 15833 15833
==========================================
- Hits 10348 10345 -3
- Misses 4738 4742 +4
+ Partials 747 746 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
artursouza
approved these changes
Jan 24, 2023
Taction
added a commit
to Taction/dapr
that referenced
this pull request
Jan 27, 2023
* master: (138 commits) Register state.sqlite component (dapr#5815) Disable the fasthttp Server header (dapr#5821) proxy test: do not fail on context canceled v2 (dapr#5818) Add CI step to detect disallowed changes to go.mod (dapr#5816) Add k6 and perftests docs (dapr#5817) Ignore context canceled errors in proxy test (dapr#5812) Dapr Workflow Engine (dapr#5784) lower log severity for binding problems (dapr#5806) Add namespaced rbac mode (dapr#5801) Update dependencies, pin new contrib (dapr#5791) gRPC proxy: fix streaming and resiliency (dapr#5777) Change dapr-operator ClusterRole[Binding] name to suffix with `-admin` (dapr#5794) Add component field to logs from components (dapr#5792) Fixed log message (dapr#5786) Updated helm install link (dapr#5790) Add performance test for bulk subscribe over HTTP (dapr#5650) Remove annotations from pluggable components injector feature (dapr#5750) Dapr Workflow Engine Part 1: Internal Actors (dapr#5761) Pin contrib for ASB and update apache dubbo replacement to address CVE (dapr#5780) Add deepanshuA to dapr bot. (dapr#5770) ... # Conflicts: # go.mod # go.sum # pkg/grpc/api.go # pkg/http/api.go
ASHIQUEMD
pushed a commit
to ASHIQUEMD/dapr
that referenced
this pull request
Feb 23, 2023
dapr#5794) Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: ashiquemd <noorani.ashique5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how Helm upgrades, upgrading from v1.9.5 to master is currently broken as
roleRefin roles cannot be updated in place.This PR reverts the ClusterRole name back to
dapr-operator-adminso it doesn't change on an upgrade, and changes the binding name to match.After a number of future versions, we would be able to remove the
adminsuffix from the role and binding names to be consistent since the upgrade would be deleting the exiting resources with another. There isn't currently a maximum version upgrade jump though so it's possible a user could always upgrade from pre 1.10 to any future version.Perhaps we should create a policy for the maximum version jump a user could perform, i.e can only upgrade from target - 2 minor versions? This would allow us to change these resource names, as well as allowing us to handle these kind of problems in future.
Broken from: #5767
/cc @yaron2