Test Integration: hardcode binary tmp for darwin #7664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Darwin (MacOS), `os.TempDir()` nicely returns a truly ephemeral process directory is `/var/folders/...` however in order to reap the benefits of Go cache magic in integration tests we need a slightly more permanent directory, i.e. `/tmp`. This directory will persist across integration test runs and speed up the test execution boot times from s to ms. Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7664 +/- ##
==========================================
- Coverage 61.87% 61.84% -0.04%
==========================================
Files 245 245
Lines 22418 22418
==========================================
- Hits 13872 13865 -7
- Misses 7385 7391 +6
- Partials 1161 1162 +1 ☔ View full report in Codecov by Sentry. |
artursouza
approved these changes
Mar 31, 2024
daixiang0
reviewed
Apr 1, 2024
| if runtime.GOOS == "darwin" { | ||
| tmpdir = "/tmp" | ||
| } else { | ||
| tmpdir = os.TempDir() |
There was a problem hiding this comment.
Is it a design issue for Go os package? Maybe we can submit an issue.
There was a problem hiding this comment.
I actually think Go is doing the more correct thing here as a sane default, however because we want a slightly more persistent target directory we need to divert from the default.
cicoyle
pushed a commit
to cicoyle/dapr
that referenced
this pull request
May 24, 2024
On Darwin (MacOS), `os.TempDir()` nicely returns a truly ephemeral process directory is `/var/folders/...` however in order to reap the benefits of Go cache magic in integration tests we need a slightly more permanent directory, i.e. `/tmp`. This directory will persist across integration test runs and speed up the test execution boot times from s to ms. Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jun 10, 2024
On Darwin (MacOS), `os.TempDir()` nicely returns a truly ephemeral process directory is `/var/folders/...` however in order to reap the benefits of Go cache magic in integration tests we need a slightly more permanent directory, i.e. `/tmp`. This directory will persist across integration test runs and speed up the test execution boot times from s to ms. Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Elena Kolevska <elena@kolevska.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin (MacOS),
os.TempDir()nicely returns a truly ephemeral process directory is/var/folders/..., however in order to reap the benefits of Go cache magic when re-building binaries between integration test runs we need a slightly more permanent directory, i.e./tmp. This directory will persist across integration test runs and speed up the test execution boot times from s to ms.Updates integration test binary builder to use
/tmpas the root dir when running on darwin.